From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9C20660995 for ; Tue, 15 Dec 2020 09:40:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8746EF27B for ; Tue, 15 Dec 2020 09:40:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1C6DBF271 for ; Tue, 15 Dec 2020 09:40:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D67F045169 for ; Tue, 15 Dec 2020 09:40:13 +0100 (CET) Date: Tue, 15 Dec 2020 09:40:07 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <5FD56B860200008800004138@mail.comsolve.nl> <5FD56B860200008800004138@mail.comsolve.nl> <1607929849.0i4pachlbl.astroid@nora.none> <5FD7F8EA0200008800004149@mail.comsolve.nl> In-Reply-To: <5FD7F8EA0200008800004149@mail.comsolve.nl> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1608021512.lhqm96y4cq.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.025 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] Feature: OAuth / OpenID-connect implementation - II X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 08:40:44 -0000 On December 15, 2020 12:44 am, Michael Honkoop wrote: > Hi all,=20 >=20 > In watching build-behaviour, i notice that when i build another git repo = (pve-manager) it drops the directory 'dest' and then ( if one deletes the r= esulting *buildinfo, *.changes and *.deb) starts rebuilding. >=20 > On the pve-access-control it does not remove the directory 'libpve-access= -control-6.1' , so when one has this dir, ( and assuming same behaviour as = seen on pve-manager repo) it will take all sources from this dir - regardle= ss of changes. >=20 > Is there a specific reason this differs from the pve-manager repo ? - as = only after analysing why my added file was skipped over and over again ( in= pve-access-control ) has lead me to a lot of questionmarks in my mind. no, no specific reason except that Makefiles tend to grow over time, and=20 sometimes improvements/changes don't make it to all of them. feel free=20 to improve upon it if you want, for the smaller repos when in doubt just=20 add a 'make clean' before your build - the build should be rather fast=20 anyway even when starting from scratch ;) =