From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0B4F762F91 for ; Tue, 24 Nov 2020 16:29:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 022D6F7DB for ; Tue, 24 Nov 2020 16:29:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4665CF7D1 for ; Tue, 24 Nov 2020 16:29:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 10214424C0 for ; Tue, 24 Nov 2020 16:29:25 +0100 (CET) Date: Tue, 24 Nov 2020 16:29:17 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20201106143059.22047-1-f.ebner@proxmox.com> <20201106143059.22047-4-f.ebner@proxmox.com> In-Reply-To: <20201106143059.22047-4-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1606231728.g2jrh59drg.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemumigrate.pm] Subject: [pve-devel] applied: [RFC v2 qemu-server 4/5] adapt to new storage_migrate activation behavior X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 15:29:56 -0000 On November 6, 2020 3:30 pm, Fabian Ebner wrote: > Offline migrated volumes are now activated within storage_migrate. > Online migrated volumes can be assumed to be already active. >=20 > Signed-off-by: Fabian Ebner > --- >=20 > dependency bump needed >=20 > Sent as RFC, because I'm not completly sure if this is fine here. > Is the assumption about online volumes correct or is there some weird > edge case I'm missing? > I only found run_replication as a potential place that might need active > local volumes, but that also uses storage_migrate in the end. >=20 > PVE/QemuMigrate.pm | 8 -------- > 1 file changed, 8 deletions(-) >=20 > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index 2f4eec3..f2c2b07 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -251,7 +251,6 @@ sub prepare { > =20 > my $vollist =3D PVE::QemuServer::get_vm_volumes($conf); > =20 > - my $need_activate =3D []; > foreach my $volid (@$vollist) { > my ($sid, $volname) =3D PVE::Storage::parse_volume_id($volid, 1); > =20 > @@ -266,16 +265,9 @@ sub prepare { > my $plugin =3D PVE::Storage::Plugin->lookup($scfg->{type}); > warn "Used shared storage '$sid' is not online on source node!\n" > if !$plugin->check_connection($sid, $scfg); > - } else { > - # only activate if not shared > - next if ($volid =3D~ m/vm-\d+-cloudinit/); > - push @$need_activate, $volid; > } > } > =20 > - # activate volumes > - PVE::Storage::activate_volumes($self->{storecfg}, $need_activate); > - > # test ssh connection > my $cmd =3D [ @{$self->{rem_ssh}}, '/bin/true' ]; > eval { $self->cmd_quiet($cmd); }; > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =