From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 74A7E62F29 for ; Wed, 28 Oct 2020 14:15:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 684DC1FCE0 for ; Wed, 28 Oct 2020 14:15:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 92B831FCD6 for ; Wed, 28 Oct 2020 14:15:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5806745BF0 for ; Wed, 28 Oct 2020 14:15:49 +0100 (CET) Date: Wed, 28 Oct 2020 14:15:41 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20201015102426.5662-1-f.ebner@proxmox.com> In-Reply-To: <20201015102426.5662-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1603890752.4d64scs2iw.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [migrate.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH container] fix #3030: activate volumes at the right time for restart migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 13:15:50 -0000 On October 15, 2020 12:24 pm, Fabian Ebner wrote: > The lxc-pve-poststop-hook deactivates volumes when a container is stopped= . > To make sure that volumes are active when using the restart mode, > move activate_volumes to after the conditional vm_stop. The lxc-stop comm= and > used in vm_stop waits for the hook script to complete, so there is no rac= e. >=20 > Signed-off-by: Fabian Ebner > --- >=20 > For VMs we don't have restart migration, so no similar bug there. >=20 > An alternative would be to communicate to the hook script to > not deactivate the volumes. That would mean writing the lock=3Dmigrate > to the config earlier (currently it's being set in phase1) and > then checking for the lock in the hookscript. isn't this still wrong, as it only activates the volumes directly=20 referenced by the config, but we storage migrate unused (referenced and=20 unreferenced) and snapshot volumes as well? wouldn't it make more sense=20 that storage_migrate ensures the passed-in volid is activated before=20 accessing it? and then before switching the container over, we ensure=20 all volids we passed to storage_migrate get deactivated.. the others=20 were already deactivated by the container shutting down anyway. >=20 > src/PVE/LXC/Migrate.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm > index 90d74b4..5ef16d2 100644 > --- a/src/PVE/LXC/Migrate.pm > +++ b/src/PVE/LXC/Migrate.pm > @@ -90,8 +90,6 @@ sub prepare { > =20 > }); > =20 > - PVE::Storage::activate_volumes($self->{storecfg}, $need_activate); > - > # todo: test if VM uses local resources > =20 > # test ssh connection > @@ -110,6 +108,8 @@ sub prepare { > $running =3D 0; > } > =20 > + PVE::Storage::activate_volumes($self->{storecfg}, $need_activate); > + > return $running; > } > =20 > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =