From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9131BBA69D for ; Thu, 14 Dec 2023 12:10:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7A55315EA8 for ; Thu, 14 Dec 2023 12:10:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Dec 2023 12:10:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4F1E84759C for ; Thu, 14 Dec 2023 12:10:51 +0100 (CET) Message-ID: <15e46ae1-12d8-4482-ba0a-7ccc0994b7eb@proxmox.com> Date: Thu, 14 Dec 2023 12:10:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Fiona Ebner , Proxmox VE development discussion References: <20231213165848.107768-1-f.schauer@proxmox.com> Content-Language: en-US From: Filip Schauer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.163 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v5 qemu-server] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2023 11:10:52 -0000 Patch v6 available: https://lists.proxmox.com/pipermail/pve-devel/2023-December/061097.html On 14/12/2023 10:46, Fiona Ebner wrote: > Am 13.12.23 um 17:58 schrieb Filip Schauer: >> @@ -719,6 +731,26 @@ sub get_cpu_from_running_vm { >> return $1; >> } >> >> +sub get_cpu_bitness { > Learned a new word today :) > >> + my ($conf, $arch) = @_; > Please pass either the CPU property string or the CPU type directly > instead of the whole config. Makes it more re-usable and modular. > >> + >> + return if !$conf or !$arch; > There always is an arch and a CPU type, so IMHO, we should make the > caller responsible for passing in something valid. I.e. I'd rather die > than "hide" the issue by returning undef. For the CPU type, we could > also fall back to the default if nothing got passed in (we got access to > $cpu_fmt in the module). > >> + >> + if ($arch eq 'x86_64') { >> + if (my $cpu_prop_str = $conf->{cpu}) { >> + my $cpu = PVE::JSONSchema::parse_property_string('pve-vm-cpu-conf', $cpu_prop_str) >> + or die "Cannot parse cpu description: $cpu_prop_str\n"; >> + >> + my $cputype = $cpu->{cputype}; >> + return 32 if $cputypes_32bit->{$cputype}; >> + } >> + >> + return 64; >> + } >> + >> + return 64 if $arch eq 'aarch64'; >> +} > I'd rather die then return undef if it's an unknown arch. Then it will > be more obvious if we forget to extend the helper. Because Perl itself > will not complain if we forget.