From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 053DC7700F for ; Mon, 19 Jul 2021 14:57:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0309326FA2 for ; Mon, 19 Jul 2021 14:57:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 498E826F94 for ; Mon, 19 Jul 2021 14:57:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 20401422F0 for ; Mon, 19 Jul 2021 14:57:42 +0200 (CEST) Message-ID: <15a01769-c3b9-5b20-b9cb-62ca8c1fb3a1@proxmox.com> Date: Mon, 19 Jul 2021 14:57:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20210719115859.735216-1-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210719115859.735216-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.467 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.07 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] vzdump: allow backups on btrfs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 12:57:43 -0000 On 19.07.21 13:58, Oguz Bektas wrote: > see forum post [0] > > [0]: > https://forum.proxmox.com/threads/cant-use-storage-type-btrfs-for-backup-500-help.92918/ > > Signed-off-by: Oguz Bektas > --- > PVE/VZDump.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm > index 46cb9e6d..39b5e46d 100644 > --- a/PVE/VZDump.pm > +++ b/PVE/VZDump.pm > @@ -102,7 +102,8 @@ sub storage_info { > > die "can't use storage type '$type' for backup\n" > if (!($type eq 'dir' || $type eq 'nfs' || $type eq 'glusterfs' > - || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs')); > + || $type eq 'cifs' || $type eq 'cephfs' || $type eq 'pbs' > + || $type eq 'btrfs')); Rather, that whole check above needs to be removed, we can derive that from $scfg->{content}->{backup} below already, that can only get set when on a storage that declares to support backups, and actually works for external ttorage plugins too. > die "can't use storage '$storage' for backups - wrong content type\n" > if (!$scfg->{content}->{backup}); > >