From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6782460915 for ; Thu, 3 Sep 2020 09:59:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C26016443 for ; Thu, 3 Sep 2020 09:58:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 55D341642A for ; Thu, 3 Sep 2020 09:58:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 20768449DA for ; Thu, 3 Sep 2020 09:58:29 +0200 (CEST) Date: Thu, 03 Sep 2020 09:58:22 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20200901124421.25901-1-a.lauterer@proxmox.com> <20200901124421.25901-5-a.lauterer@proxmox.com> In-Reply-To: <20200901124421.25901-5-a.lauterer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1599119807.ye2lhdunc6.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cephfsplugin.pm, drbdplugin.pm, proxmox.com, zfsplugin.pm, glusterfsplugin.pm, iscsidirectplugin.pm, iscsiplugin.pm] Subject: Re: [pve-devel] [PATCH v2 storage 4/5] disk reassign: add not implemented yet message to storages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2020 07:59:00 -0000 wouldn't it make more sense to implement it in Dir/NFS/CIFSPlugin, and=20 add this 'implement me' into Plugin itself? otherwise this breaks=20 external plugins. also, would it make sense to add a feature for this so=20 that we can check in the calling code with a meaningful error message=20 before attempting and die-ing? On September 1, 2020 2:44 pm, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > rfc -> v1 -> v2: nothing changed >=20 > PVE/Storage/CephFSPlugin.pm | 5 +++++ > PVE/Storage/DRBDPlugin.pm | 5 +++++ > PVE/Storage/GlusterfsPlugin.pm | 5 +++++ > PVE/Storage/ISCSIDirectPlugin.pm | 5 +++++ > PVE/Storage/ISCSIPlugin.pm | 4 ++++ > PVE/Storage/ZFSPlugin.pm | 5 +++++ > 6 files changed, 29 insertions(+) >=20 > diff --git a/PVE/Storage/CephFSPlugin.pm b/PVE/Storage/CephFSPlugin.pm > index 880ec05..ba31366 100644 > --- a/PVE/Storage/CephFSPlugin.pm > +++ b/PVE/Storage/CephFSPlugin.pm > @@ -222,4 +222,9 @@ sub deactivate_storage { > } > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + die "Not implemented for this storage type\n"; > +} > + > 1; > diff --git a/PVE/Storage/DRBDPlugin.pm b/PVE/Storage/DRBDPlugin.pm > index dbae4d1..304ade7 100644 > --- a/PVE/Storage/DRBDPlugin.pm > +++ b/PVE/Storage/DRBDPlugin.pm > @@ -404,4 +404,9 @@ sub volume_has_feature { > return undef; > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + die "Not implemented for this storage type\n"; > +} > + > 1; > diff --git a/PVE/Storage/GlusterfsPlugin.pm b/PVE/Storage/GlusterfsPlugin= .pm > index 2dd414d..831d2ef 100644 > --- a/PVE/Storage/GlusterfsPlugin.pm > +++ b/PVE/Storage/GlusterfsPlugin.pm > @@ -348,4 +348,9 @@ sub check_connection { > return defined($server) ? 1 : 0; > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + die "Not implemented for this storage type\n"; > +} > + > 1; > diff --git a/PVE/Storage/ISCSIDirectPlugin.pm b/PVE/Storage/ISCSIDirectPl= ugin.pm > index 9777969..8d72173 100644 > --- a/PVE/Storage/ISCSIDirectPlugin.pm > +++ b/PVE/Storage/ISCSIDirectPlugin.pm > @@ -252,4 +252,9 @@ sub volume_has_feature { > return undef; > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + die "Not implemented for this storage type\n"; > +} > + > 1; > diff --git a/PVE/Storage/ISCSIPlugin.pm b/PVE/Storage/ISCSIPlugin.pm > index f2694ba..602fb1d 100644 > --- a/PVE/Storage/ISCSIPlugin.pm > +++ b/PVE/Storage/ISCSIPlugin.pm > @@ -438,5 +438,9 @@ sub volume_has_feature { > return undef; > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + die "Not implemented for this storage type\n"; > +} > =20 > 1; > diff --git a/PVE/Storage/ZFSPlugin.pm b/PVE/Storage/ZFSPlugin.pm > index 383f0a0..4097b1a 100644 > --- a/PVE/Storage/ZFSPlugin.pm > +++ b/PVE/Storage/ZFSPlugin.pm > @@ -421,4 +421,9 @@ sub deactivate_volume { > return 1; > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + die "Not implemented for this storage type\n"; > +} > + > 1; > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =