From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5C4906A300 for ; Tue, 11 Aug 2020 14:36:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59D5B1D8AA for ; Tue, 11 Aug 2020 14:36:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 921B31D8A0 for ; Tue, 11 Aug 2020 14:36:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5E9F644531 for ; Tue, 11 Aug 2020 14:36:24 +0200 (CEST) Date: Tue, 11 Aug 2020 14:36:18 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20200804113244.26810-1-f.ebner@proxmox.com> In-Reply-To: <20200804113244.26810-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1597149316.pyafbcpqc0.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH qemu-server 1/2] Fix #2816: increase timeout for allocation on restore X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2020 12:36:25 -0000 On August 4, 2020 1:32 pm, Fabian Ebner wrote: > qcow2 images are allocated with --preallocation=3Dmetadata, > which can take a while for large images. > Avoid using 'got timeout' as an error message by itself, > to make it clearer where a timeout occured. >=20 > Signed-off-by: Fabian Ebner > --- > PVE/QemuServer.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 0a09f3a..8b0b2c8 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -6261,7 +6261,7 @@ sub restore_vma_archive { > local $SIG{QUIT} =3D > local $SIG{HUP} =3D > local $SIG{PIPE} =3D sub { die "interrupted by signal\n"; }; > - local $SIG{ALRM} =3D sub { die "got timeout\n"; }; > + local $SIG{ALRM} =3D sub { die "got timeout preparing device images\n";= }; > =20 > $oldtimeout =3D alarm($timeout); > =20 > @@ -6275,9 +6275,9 @@ sub restore_vma_archive { > $devinfo->{$devname} =3D { size =3D> $size, dev_id =3D> $dev_id }; > } elsif ($line =3D~ m/^CTIME: /) { > # we correctly received the vma config, so we can disable > - # the timeout now for disk allocation (set to 10 minutes, so > + # the timeout now for disk allocation (set to 1 hour, so > # that we always timeout if something goes wrong) do we really need this timeout? we are by definition in a worker=20 already, instead of moving the goal post once more could we not drop=20 this and let the user hit 'Stop' if the allocation stalls altogether? > - alarm(600); > + alarm(60 * 60); > &$print_devmap(); > print $fifofh "done\n"; > my $tmp =3D $oldtimeout || 0; > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =