From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7E55B6A262 for ; Tue, 11 Aug 2020 14:32:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C0B51D7DF for ; Tue, 11 Aug 2020 14:32:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C2A2F1D7D5 for ; Tue, 11 Aug 2020 14:32:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8D79644598 for ; Tue, 11 Aug 2020 14:32:58 +0200 (CEST) Date: Tue, 11 Aug 2020 14:32:52 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20200804094638.25399-1-a.lauterer@proxmox.com> In-Reply-To: <20200804094638.25399-1-a.lauterer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1597149165.wkwa2vmjmd.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.038 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, vzdump.pm] Subject: [pve-devel] applied: [PATCH manager] backup: fix #2913 order jobs numerically by VMID X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2020 12:32:59 -0000 On August 4, 2020 11:46 am, Aaron Lauterer wrote: > At this point, the VMIDs are already numerically sorted by the > PVE::VZDump::check_vmids method. Calling another sort on the array, > especially without `{$a <=3D> $b}`, resulted in reordering the array > alphabetically. >=20 > Signed-off-by: Aaron Lauterer > --- > PVE/VZDump.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm > index f80faeff..88437bd7 100644 > --- a/PVE/VZDump.pm > +++ b/PVE/VZDump.pm > @@ -1048,7 +1048,7 @@ sub exec_backup { > } > =20 > my $vmlist =3D PVE::Cluster::get_vmlist(); > - foreach my $vmid (sort @{$opts->{vmids}}) { > + foreach my $vmid (@{$opts->{vmids}}) { > my $guest_type =3D $vmlist->{ids}->{$vmid}->{type}; > my $plugin =3D $vzdump_plugins->{$guest_type}; > next if !$rpcenv->check($authuser, "/vms/$vmid", [ 'VM.Backup' ], $opts= ->{all}); > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =