From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id F11961FF165
	for <inbox@lore.proxmox.com>; Thu, 10 Apr 2025 13:25:28 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 103D439243;
	Thu, 10 Apr 2025 13:25:23 +0200 (CEST)
Date: Thu, 10 Apr 2025 13:24:47 +0200 (CEST)
From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <1589334087.2123.1744284288000@192.168.2.153>
In-Reply-To: <20250410105046.897410-1-d.csapak@proxmox.com>
References: <20250410105046.897410-1-d.csapak@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev75
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.046 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [RFC PATCH backup-restore-image] enable the
 codepage 437 for FAT filesystems
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

https://lore.proxmox.com/all/20241126132602.576027-1-s.ivanov@proxmox.com/ ;)

also see some discussions on v1 there: https://lore.proxmox.com/all/20241126120357.389046-1-s.ivanov@proxmox.com/

> Dominik Csapak <d.csapak@proxmox.com> hat am 10.04.2025 12:50 CEST geschrieben:
> 
>  
> This enables mounting fat32 formatted volumes, since codepage 437 is the
> default when mounting such volumes. (E.g. this also allows mounting EFI
> partitions)
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> stumbled upon this while doing file restore tests
> 
> Not sure if we just want to enable this one codepage or more. In our
> normal kernel build, this is enabled by default (and marked as such),
> and the others are built as modules.
> 
>  src/config-base | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/config-base b/src/config-base
> index 1581b09..edd95c1 100644
> --- a/src/config-base
> +++ b/src/config-base
> @@ -102,6 +102,7 @@ CONFIG_SYSFS=y
>  CONFIG_NLS=y
>  CONFIG_NLS_UTF8=y
>  CONFIG_NLS_ISO8859_1=y
> +CONFIG_NLS_CODEPAGE_437=y
>  CONFIG_MSDOS_PARTITION=y
>  CONFIG_EFI_PARTITION=y
>  CONFIG_FILE_LOCKING=y
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel