From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E70B41FF16B for <inbox@lore.proxmox.com>; Thu, 6 Feb 2025 13:45:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D9FF1EC6B; Thu, 6 Feb 2025 13:45:43 +0100 (CET) Message-ID: <14c0c179-6ea7-439c-a9ef-77cdaf944d9e@proxmox.com> Date: Thu, 6 Feb 2025 13:45:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Alexander Abraham <a.abraham@proxmox.com> References: <20250205124127.111180-1-a.abraham@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20250205124127.111180-1-a.abraham@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.497 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.108.153, 185.199.110.153, 185.199.111.153] Subject: Re: [pve-devel] [PATCH pve-docs v3] fix #5644: Split the section on creating a swap partition on a ZVol. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Nit: we usually don't use a dot at the end of a commit title Am 05.02.25 um 13:41 schrieb Alexander Abraham: > The section "SWAP on ZFS" was split into two parts. The first part > contains general instructions on how to create a swap partition and > how to set the level of "swappiness". The second part contains a > warning about creating a swap partition on a ZFS volume.The official > ZFS documentation, which has been linked in a footnote, explains > that creating a swap partition on a ZFS volume could lead to > dangerous and undefined behavior. > > Signed-off-by: Alexander Abraham <a.abraham@proxmox.com> Shaping up nicely now! A few more comments/nits below. > --- > local-zfs.adoc | 26 +++++++++++++++----------- > 1 file changed, 15 insertions(+), 11 deletions(-) > > diff --git a/local-zfs.adoc b/local-zfs.adoc > index c64fb27..d411222 100644 > --- a/local-zfs.adoc > +++ b/local-zfs.adoc > @@ -622,14 +622,9 @@ time this value changes: > You *must reboot* to activate these changes. > ==== > > - > -[[zfs_swap]] > -SWAP on ZFS > -~~~~~~~~~~~ > - > -Swap-space created on a zvol may generate some troubles, like blocking the > -server or generating a high IO load, often seen when starting a Backup > -to an external Storage. > +[[creating_swap_partitions]] > +Creating SWAP Partitions > +~~~~~~~~~~~~~~~~~~~~~~~~ > This is not related to ZFS, so a second patch could move this section to a different place, see Alexander Zeidler's suggestion in v2: https://lore.proxmox.com/pve-devel/D7ITC3NDGSV5.1S3BV4L2Q49LF@proxmox.com/ > We strongly recommend to use enough memory, so that you normally do not > run into low memory situations. Should you need or want to add swap, it is > @@ -637,18 +632,18 @@ preferred to create a partition on a physical disk and use it as a swap device. > You can leave some space free for this purpose in the advanced options of the > installer. Additionally, you can lower the > ``swappiness'' value. A good value for servers is 10: > - > + > ---- > # sysctl -w vm.swappiness=10 > ---- > - > + > To make the swappiness persistent, open `/etc/sysctl.conf` with > an editor of your choice and add the following line: > > -------- > vm.swappiness = 10 > -------- > - > + > .Linux kernel `swappiness` parameter values > [width="100%",cols="<m,2d",options="header"] > |=========================================================== Is there a specific reason behind these whitespace changes or were they done by accident? > @@ -663,6 +658,15 @@ improve performance when sufficient memory exists in a system. > | vm.swappiness = 100 | The kernel will swap aggressively. > |=========================================================== > > +[[zfs_swap]] > +SWAP on ZFS > +~~~~~~~~~~~ > + > +It is strongly recommended to not use a ZFS volume for creating a swap partition Missing a comma before "because" > +because this could lead to deadlocks. These deadlocks could cause the affected Nit: I'd replace "could" with "can" both times > +system to freeze. The OpenZFS documentation footnote:[https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux] Nit: I'd move the footnote link on its own line, then it will overshoot the line length a bit less. > +warns about using a ZFS volume for creating a swap partition. > + > [[zfs_encryption]] > Encrypted ZFS Datasets > ~~~~~~~~~~~~~~~~~~~~~~ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel