From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D509291763 for ; Mon, 14 Nov 2022 11:13:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1B7821AC3 for ; Mon, 14 Nov 2022 11:13:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 14 Nov 2022 11:13:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE09E43CAF for ; Mon, 14 Nov 2022 11:13:00 +0100 (CET) Message-ID: <1477baac-d0ee-39da-676f-6a2a220bc355@proxmox.com> Date: Mon, 14 Nov 2022 11:13:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20221111150527.538248-1-s.sterz@proxmox.com> <20221111150527.538248-3-s.sterz@proxmox.com> <2ff2f3db-7243-d1e8-a710-8e8ea4adddd0@proxmox.com> From: Stefan Sterz In-Reply-To: <2ff2f3db-7243-d1e8-a710-8e8ea4adddd0@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.102 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2022 10:13:01 -0000 On 11/14/22 11:07, Thomas Lamprecht wrote: > Am 14/11/2022 um 09:26 schrieb Stefan Sterz: >>> IIUC this indirectly raised the minimum length of references to two characters, >>> not a deal breaker IMO as I don't really expect two characters to be used anytime >>> soon (maybe with unicode 🤔🧠💭 x)), but maybe hint it in the commit message. >>> >> yes that is correct. just to have made the suggestion: the "[^}]" could >> be dropped here. that should get us back down to one character, but will >> also filter the necessary keys. and anchors like "{key" are just as >> invalid as "{key}" in asciidoc. >> > > > or move it to a single one replacing the whole non-greedy part, something like > (untested): [^{}\[\]"']+ > should work to, yes. i used grep to test this and it worked (i did need to do some escaping for the quotes, but the idea seems solid). i'll send a v3 with this if you approve :)