From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 0C6201FF16F
for <inbox@lore.proxmox.com>; Tue, 24 Jun 2025 13:30:18 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 32C5E352A8;
Tue, 24 Jun 2025 13:30:52 +0200 (CEST)
Message-ID: <13ae3cda-112f-49b0-9f73-fd8e2379f86c@proxmox.com>
Date: Tue, 24 Jun 2025 13:30:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
References: <20250612095548.137819-1-l.wagner@proxmox.com>
Content-Language: de-AT, en-US
In-Reply-To: <20250612095548.137819-1-l.wagner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.020 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] superseded: [PATCH manager 1/2] ui: remove handling of
obsolete notification-policy/target settings
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Superseded-by:
https://lore.proxmox.com/all/20250624112817.132312-1-l.wagner@proxmox.com/T/#t
On 2025-06-12 11:55, Lukas Wagner wrote:
> These were only used in the 'old' revamped notification stack which was
> briefly available on pvetest. With PVE 9 we can finally get completely
> rid of these.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> Only intended for PVE 9.
>
> www/manager6/dc/Backup.js | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 381402ca..688befe7 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -37,14 +37,6 @@ Ext.define('PVE.dc.BackupEdit', {
> delete values.node;
> }
>
> - // Get rid of new-old parameters for notification settings.
> - // These should only be set for those selected few who ran
> - // pve-manager from pvetest.
> - if (!isCreate) {
> - Proxmox.Utils.assemble_field_data(values, { 'delete': 'notification-policy' });
> - Proxmox.Utils.assemble_field_data(values, { 'delete': 'notification-target' });
> - }
> -
> let selMode = values.selMode;
> delete values.selMode;
>
> @@ -158,14 +150,6 @@ Ext.define('PVE.dc.BackupEdit', {
> let me = this;
> let viewModel = me.getViewModel();
>
> - // Migrate 'new'-old notification-policy back to old-old mailnotification.
> - // Only should affect users who used pve-manager from pvetest. This was a remnant of
> - // notifications before the overhaul.
> - let policy = data['notification-policy'];
> - if (policy === 'always' || policy === 'failure') {
> - data.mailnotification = policy;
> - }
> -
> if (data.exclude) {
> data.vmid = data.exclude;
> data.selMode = 'exclude';
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel