From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0C471717F9 for ; Thu, 12 May 2022 17:13:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 02FA92942B for ; Thu, 12 May 2022 17:13:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2506229420 for ; Thu, 12 May 2022 17:13:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE954434B9 for ; Thu, 12 May 2022 17:13:47 +0200 (CEST) Message-ID: <1390d06b-f06a-2518-8d99-5cb074abb9f2@proxmox.com> Date: Thu, 12 May 2022 17:13:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Proxmox VE development discussion , Daniel Tschlatscher References: <20220506123910.146775-1-d.tschlatscher@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220506123910.146775-1-d.tschlatscher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] applied: [PATCH manager v2] fix #3994: Options menu entry in the System menu X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2022 15:13:49 -0000 Am 5/6/22 um 14:39 schrieb Daniel Tschlatscher: > Add the subentry "Options" in the "System" menu to expose some options > in the GUI which were not exposed before. > > Added a new file for displaying and editing the node config options > which were not exposed through the GUI yet. Namely those are the > settings for wakeonlan and startall-on-boot-delay. Edited the Makefile > to include the newly created file. > > Signed-off-by: Daniel Tschlatscher > --- > Changes from v2: > > - Moved the file from the widget-toolkit to the pve-manager repository > because it implements PVE specific functionality. > - I originally rewrote this class to use a ViewController, but then > found out that the ObjectGrid does most of what I wanted already, I > just had to address it correctly. > This means the code is now a bit shorter and a lot more concise. > > www/manager6/Makefile | 1 + > www/manager6/node/Config.js | 9 ++++ > www/manager6/node/NodeOptionsView.js | 67 ++++++++++++++++++++++++++++ > 3 files changed, 77 insertions(+) > create mode 100644 www/manager6/node/NodeOptionsView.js > > applied, thanks! I moved it one item below, as IMO DNS and Host are too related to be split by some general "Options" navigation entry. Some other points to improve: - setting the online help, maybe to 'proxmox_node_management' which would make it point to: https://pve.proxmox.com/pve-docs/chapter-sysadmin.html#proxmox_node_management (the chapter could maybe do good with some addition w.r.t. first start delay - It's not clear what unit the start delay has, you could mention that explicitly, simplest way to do so is adding a ' (s)' to the fieldLabel after the gettext. - Wake on LAN could do with a "Local MAC Address" emptyText, combined with the onlineHelp button it should then be clear enough. can you please look into those? FYI and not directly related: if we ever expose the vzdump.conf options over GUI I'd also add them here in this panel, as subpanel; would be a good use of all that empty space ;-)