From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 471F41FF170 for <inbox@lore.proxmox.com>; Tue, 19 Nov 2024 09:44:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7FC291D5D6; Tue, 19 Nov 2024 09:44:42 +0100 (CET) Message-ID: <13859146-44f2-44a9-8bfd-ae986165d12f@proxmox.com> Date: Tue, 19 Nov 2024 09:44:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Lukas Wagner <l.wagner@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20241115151749.633407-1-d.csapak@proxmox.com> <D5PBS0NDDO22.3ENLUV15D4DG4@proxmox.com> <6efce1fc-0e03-4966-ac3a-ee433f2acc01@proxmox.com> <D5PCHKPRRKZC.335GKK7ESX61O@proxmox.com> <21c1cac9-3e70-4b37-9767-d5cc160c9ca9@proxmox.com> <039ab04f-48e2-4285-91c3-ffe95ee372b9@proxmox.com> <D5Q07WV14ROB.3BIJYETI77TBU@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <D5Q07WV14ROB.3BIJYETI77TBU@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 11/19/24 09:15, Lukas Wagner wrote: > On Mon Nov 18, 2024 at 2:53 PM CET, Dominik Csapak wrote: >>>> nothing special, I tested the feature using the Home Assistant .ova from >>>> [1]. Downloaded the OVA to my local storage, pressed "import", did not >>>> change *any* settings apart from ticking "live import". >>>> The import works, but the VM is not started. Starting the VM manually >>>> works fine, also the tasks log does not show anything of concern. >>>> In the browser network requests I saw that 'live-restore' is set to '1' >>>> in the import POST request. >>>> >>>> [1] https://www.home-assistant.io/installation/alternative/ >>> >>> >>> mhmm can reproduce with that ova image, maybe it has something to do with our >>> ovf import not detecting the main disk? >>> (at least here it does not detect any disk) >>> >>> >> >> ok two things here: >> >> * this ova is malformed it seems, it has a HostResource of '/disk/vmidsk1' when >> the spec says it should be of the form 'ovf:/disk/vmdisk1' which is what we look for >> (we could make that optional though?) >> >> * seemingly live-import does not start the vm if there was no disk, but AFAICS >> this was pre-existing and not something my series introduced (but not sure either) >> > > Ah, thanks for the investigation. Maybe it'd be worth to check whether > other hypervisors accept the malformed resource definition and then add > support to PVE as well if this is the case. actually thomas fixed that yesterday already: https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=f2a6bd278896f4354f88cf828dc690d186126741 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel