From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <a.lauterer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 6BF8092D00
 for <pve-devel@lists.proxmox.com>; Wed, 14 Sep 2022 16:15:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 5FD0F2D333
 for <pve-devel@lists.proxmox.com>; Wed, 14 Sep 2022 16:15:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Wed, 14 Sep 2022 16:15:13 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 931B0441FD
 for <pve-devel@lists.proxmox.com>; Wed, 14 Sep 2022 16:15:13 +0200 (CEST)
Message-ID: <13735749-96a5-89d3-ddf0-411f5012ab79@proxmox.com>
Date: Wed, 14 Sep 2022 16:15:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Dominik Csapak <d.csapak@proxmox.com>
References: <20220621092012.1776825-1-d.csapak@proxmox.com>
 <20220621092012.1776825-19-d.csapak@proxmox.com>
Content-Language: en-US
In-Reply-To: <20220621092012.1776825-19-d.csapak@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.768 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -1.583 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH manager v7 08/14] ui: add form/TagEdit.js
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 14 Sep 2022 14:15:14 -0000

Out of curiosity, did you decide to use the older style of component, instead of 
the newer declarative approach, to be able to have references to the buttons as 
"me.<button>" instead of having to do lookups all the time?

one more thing inline

On 6/21/22 11:20, Dominik Csapak wrote:
> this is a wrapper container for holding a list of (editable) tags
> intended to be used in the lxc/qemu status toolbar
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   www/manager6/Makefile        |   1 +
>   www/manager6/form/TagEdit.js | 151 +++++++++++++++++++++++++++++++++++
>   2 files changed, 152 insertions(+)
>   create mode 100644 www/manager6/form/TagEdit.js
> 
> diff --git a/www/manager6/Makefile b/www/manager6/Makefile
> index 9d610f71..eb4be4c5 100644
> --- a/www/manager6/Makefile
> +++ b/www/manager6/Makefile
> @@ -75,6 +75,7 @@ JSSRC= 							\
>   	form/iScsiProviderSelector.js			\
>   	form/TagColorGrid.js				\
>   	form/Tag.js					\
> +	form/TagEdit.js					\
>   	grid/BackupView.js				\
>   	grid/FirewallAliases.js				\
>   	grid/FirewallOptions.js				\
> diff --git a/www/manager6/form/TagEdit.js b/www/manager6/form/TagEdit.js
> new file mode 100644
> index 00000000..5a267169
> --- /dev/null
> +++ b/www/manager6/form/TagEdit.js
> @@ -0,0 +1,151 @@
> +Ext.define('PVE.panel.TagEditContainer', {
> +    extend: 'Ext.container.Container',
> +    alias: 'widget.pveTagEditContainer',
> +
> +    tagCount: 0,
> +
> +    layout: {
> +	type: 'hbox',
> +	align: 'stretch',
> +    },
> +
> +    loadTags: function(tagstring = '', inEdit, force = false) {
> +	let me = this;
> +
> +	if (me.oldTags === tagstring && !force) {
> +	    return;
> +	}
> +
> +	let tags = tagstring.split(/[;, ]/).filter((t) => !!t) || [];

This is used at least 3 times throughout this series. Would it make sense to put 
it into a small util helper function to have it in one place?

[...]