From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6884E61081 for ; Mon, 12 Oct 2020 18:37:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B889277AB for ; Mon, 12 Oct 2020 18:37:21 +0200 (CEST) Received: from pmg.fws.fr (pmg.fws.fr [51.91.175.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7183F2779E for ; Mon, 12 Oct 2020 18:37:19 +0200 (CEST) Received: from pmg.fws.fr (localhost [127.0.0.1]) by pmg.fws.fr (Proxmox) with ESMTP id A244CC2F99 for ; Mon, 12 Oct 2020 18:37:12 +0200 (CEST) Received: from zmproxy.fws.fr (zmproxy.fws.fr [10.29.1.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pmg.fws.fr (Proxmox) with ESMTPS id 73ED1C05FF for ; Mon, 12 Oct 2020 18:37:09 +0200 (CEST) Received: from zmproxy.fws.fr (localhost [127.0.0.1]) by zmproxy.fws.fr (Postfix) with ESMTPS id 696718B3580; Mon, 12 Oct 2020 18:37:09 +0200 (CEST) Received: from zmproxy.fws.fr (localhost [127.0.0.1]) by zmproxy.fws.fr (Postfix) with ESMTPS id 51A9A8B79BF; Mon, 12 Oct 2020 18:37:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 zmproxy.fws.fr 51A9A8B79BF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=firewall-services.com; s=7DAD15A2-D84A-11E9-8F77-BEC4FAA34EBC; t=1602520629; bh=bOvcFhADeCYU6HUO3ZCCtlvtZfbWiTbyy/86l+IMIrA=; h=Date:From:To:Message-ID:MIME-Version; b=MXSE67W4D/IxOHqnbLAtscJ4ooNkSwVVubZrjrwjaRggnKQUu5tOvkB1fRbBHsueQ FUkNou1HzpFQE+Kvso93lSaD3cgC4l6MeaCOOeIrWp9Xfvy1+MpEbDfk99j8Bhb21S giJ8l9VOa6rIfJUe2DL7MmoQKhwM1oK2IME7v2aFrxDPd3oZxIEezUj7SKIAFbBmuG IRVJK7aQcLZxYnaHu7eMkzkmy0YfjnWzjUFzpAA4wg5yeRcdy9wQkd4xsZDdwynJMC MHXTKVe5oSKCtQig53Rf0nBZTvo4GBcJwUgeRFZN3NuE3EemcvP2wRD8qjJOpbjwwS nDAlfjgmELYcA== Received: from zmstore.fws.fr (zmstore.fws.fr [10.29.3.15]) by zmproxy.fws.fr (Postfix) with ESMTP id 4CBE98B3580 for ; Mon, 12 Oct 2020 18:37:09 +0200 (CEST) Date: Mon, 12 Oct 2020 18:37:09 +0200 (CEST) From: Daniel Berteaud To: Proxmox VE development discussion Message-ID: <1366393006.227944.1602520629190.JavaMail.zimbra@fws.fr> In-Reply-To: <20201012153458.18685-1-s.ivanov@proxmox.com> References: <20201012153458.18685-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.29.1.17] X-Mailer: Zimbra 8.8.15_GA_3963 (ZimbraWebClient - GC85 (Linux)/8.8.15_GA_3963) Thread-Topic: fix tainted config and minor cleanup Thread-Index: Y03oZcy6u6RAyKF0sAxV7ydmzeV0Ww== X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage 0/2] LIO: fix tainted config and minor cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2020 16:37:51 -0000 ----- Le 12 Oct 20, =C3=A0 17:34, Stoiko Ivanov s.ivanov@proxmox.com a =C3= =A9crit : > This patchset follows the fix in 609f117ff24d2cff6b155e1d4b1175ceebe5bd7b= . > Since several operations rely on values read from the remote target's > LIO config (which is tainted), this patchset untaints the settings, which= are > actually needed (and stores only those), while reading the config. >=20 > The second patch removes two small left-over statements, which confused m= e > while debugging. >=20 > Tested very roughly (adding disks, create/rollback snapshot, remove disk)= on > a VM backed by a LIO-iSCSI target. >=20 Just tested it on my install, and everything seems to be working again (tes= ted disk creation, removal, resize, move, snapshot, rollback, delete snapsh= ot) Thanks ! --=20 [ https://www.firewall-services.com/ ] =09 Daniel Berteaud=20 FIREWALL-SERVICES SAS, La s=C3=A9curit=C3=A9 des r=C3=A9seaux=20 Soci=C3=A9t=C3=A9 de Services en Logiciels Libres=20 T=C3=A9l : +33.5 56 64 15 32=20 Matrix: @dani:fws.fr=20 [ https://www.firewall-services.com/ | https://www.firewall-services.com ]