From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 33A931FF15E for <inbox@lore.proxmox.com>; Tue, 25 Mar 2025 17:36:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C50D0F2F9; Tue, 25 Mar 2025 17:36:29 +0100 (CET) Date: Tue, 25 Mar 2025 17:35:55 +0100 (CET) From: Mira Limbeck <m.limbeck@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Thomas Skinner <thomas@atskinner.net> Message-ID: <1345234902.2549.1742920555171@webmail.proxmox.com> In-Reply-To: <20250324023728.1294436-1-thomas@atskinner.net> References: <20250324023728.1294436-1-thomas@atskinner.net> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev74 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.289 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH SERIES access-control/docs/manager/proxmox-openid v4] fix #4411: add support for openid groups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> > Thomas Skinner <thomas@atskinner.net> hat am 24.03.2025 03:37 CET geschrieben: > > > Changes since v3: > - removed all code/settings/docs for group name replacement characters > - conditionally print user added to groups message > > access-control: > > Thomas Skinner (1): > fix #4411: openid: add logic for openid groups support > > src/PVE/API2/OpenId.pm | 83 ++++++++++++++++++++++++++++++++++++++++ > src/PVE/AccessControl.pm | 2 +- > src/PVE/Auth/OpenId.pm | 25 ++++++++++++ > src/PVE/Auth/Plugin.pm | 1 + > 4 files changed, 110 insertions(+), 1 deletion(-) > > > docs: > > Thomas Skinner (1): > fix #4411: openid: add docs for openid groups support > > pveum.adoc | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > > manager: > > Thomas Skinner (1): > fix #4411: openid: add ui config for openid groups support > > www/manager6/dc/AuthEditOpenId.js | 34 ++++++++++++++++++++++++++++--- > > > proxmox-openid: > > Thomas Skinner (1): > fix #4411: openid: add library code for generic id token claim support > > proxmox-openid/src/lib.rs | 55 +++++++++++++++++++++++++++++++++------ > -- > 2.39.5 > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel Thank you for the v4! I gave it a spin with Authentik again as OIDC provider. It behaved as expected, including the log message for invalid group names: ``` Mar 25 17:24:26 pve80-ceph18-staging-1 pvedaemon[31077]: openid group 'test!2345' contains invalid characters ``` One small issue with the docs patch, but other than that: Tested-by: Mira Limbeck <m.limbeck@proxmox.com> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel