From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id 7C11A6B032 for ; Mon, 2 Aug 2021 16:40:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 64EBC9984 for ; Mon, 2 Aug 2021 16:40:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 63E469976 for ; Mon, 2 Aug 2021 16:40:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 2D2A94101F; Mon, 2 Aug 2021 16:40:24 +0200 (CEST) Message-ID: <134200f3-16e4-ea17-5242-efddd464d346@proxmox.com> Date: Mon, 2 Aug 2021 16:40:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Proxmox VE development discussion , Lorenz Stechauner References: <20210722130631.237107-1-l.stechauner@proxmox.com> <20210722130631.237107-10-l.stechauner@proxmox.com> From: Dominik Csapak In-Reply-To: <20210722130631.237107-10-l.stechauner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.525 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.08 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 manager 5/5] ui/UplaodToStorage: check file extension X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2021 14:40:55 -0000 comment inline On 7/22/21 15:06, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > www/manager6/window/UploadToStorage.js | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js > index c63de16a..3f4596ce 100644 > --- a/www/manager6/window/UploadToStorage.js > +++ b/www/manager6/window/UploadToStorage.js > @@ -156,6 +156,20 @@ Ext.define('PVE.window.UploadToStorage', { > checksum.allowBlank = false; > } > }, > + > + filenameChange: function(field) { > + const view = this.getView(); > + const filename = field.getValue(); as before, this is available as second parameter. > + for (let ext of view.acceptedExtensions[view.content]) { > + if (filename.endsWith(ext)) { > + field.setValidation(); > + field.validate(); > + return; > + } > + } > + field.setValidation("wrong file extension"); > + field.validate(); > + }, would that not fit better in the 'validator' function? > }, > > items: [ > @@ -193,6 +207,9 @@ Ext.define('PVE.window.UploadToStorage', { > bind: { > value: '{filename}', > }, > + listeners: { > + change: 'filenameChange', > + }, > }, > { > xtype: 'displayfield', >