From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E434E1FF0B4 for ; Tue, 08 Sep 2026 12:19:49 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5F4AE215FD; Tue, 08 Sep 2026 12:19:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788862731; x=1789467531; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l99Lf3hLwpWPne1vEH8IFhuIa7Z4TzYxeuhMX8NJMCg=; b=bIUoPY/pCnPOFeAhk+cf3QgTbueThDWFahbRg1REhNnWnW4DSupPT48uR2PY1gRsbb ynX6i0YhJLyw3/fB8GlSiSv+cpkfoHer1gzGD/3B0fhl/uF6tRMtgkqSIkwtLv2mci7/ qVjyYi7BAAk3I2MLmJBn0uYAu5ZqiXsznhJQms1n8WIzB1AJuIMpeTqrrR1SxTgjKKOk 9eJg0Gh9O3Wgz9Xzk7+l7NraBpl9xzRvrQdsjI0vNkJXAHH5YmNv4Y20dHyQAGrAcSt+ S61Vl5ceFPFxGhxehwRWrMIZIE9+O9WJXeGHDSAgbM3SbT7tb6yaW+gGBMlSI8YCSoOt lwPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788862731; x=1789467531; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l99Lf3hLwpWPne1vEH8IFhuIa7Z4TzYxeuhMX8NJMCg=; b=kJg9XaF803i4Pw8MfqKTEUQ/3+gyKF9ESvwruq5XrTj0O9M2Knd2Wy9cR6SKyWIkZ1 kv4QflkWnpGwjJ4WpnMjH18hDZP2dEcplQx1HF8NXtLc9ZzqdGsDabbKY+qkn1Q+PxSo wtktTnSpf5uEWDSU+cwOezQIcyVEFLH6W8ff+fiTSpL0oJpeJIirii1xB4qqFlc7B8AH 5CPzKUgfYmAAyJD0TxR56SPM6Z1fa3W1DZyE+U402F2wxgbpYsoiwvfaHjVO7B1M4vWM 8+Btc8d3ip9VV2j2HUEIANtp0sBIH8ieWBCZPuzO9rYmffzSINrr7lQx/WfMoIicn5zR bKoQ== X-Forwarded-Encrypted: i=1; AKwUvBwgD62mle1lmnD7/gJdP4p/tYuYfsr8yPIwRiAV2Gm6ucSJVJjfdVejMhhctlsI47422FZhzHh0464=@lists.proxmox.com X-Gm-Message-State: AFuF++mBGAtpobgzIqwS6ZulWqtjvPoFOTwU1OcRtycnfcruUKWLDvn9 OldWcw73SfFZDw4uHF2S2fE/X08y0QRA7YOQw6YQyb7FAM6VbdbJgY8R X-Gm-Gg: AYBFou2zRkYi0/CevE2SK2Rf/jh1V6/QtBeCz+YJm4RkV8VYas8s0yvJbPh70hAWGBw Z3opXy2IeEdtTYQQkm3ATdtzf64pjx1YgG4yH56Ixz9bj1F3NbOQxqg5oLQ7Fl0Qf+Hmb06yXmZ flgWZFu+R+zgbOuGD1IjRr8l/bMS+g7cOa7IzwUq3J4Q07MESIUJOuR0EnB9dja8gAAyEEIJnlD XUrsF3QquKryFL6LSzob+RdGx3WRLUKPNubk9NxgalXEupK/0Wfp/FYXzoRIwNsQRLLM1mu/LMs m8YCdIyLqvcO6vi1JneQkuk7FKoIgk47g++Jcfe8IWYs0TI+JAS94swPAyV+YKaPOKoVL8zQfl+ fHEH7S2Kjq5KnaPLEPmp6ZT4HSK94CraqU7nlQMuXYVkKqLp8bp7+s5j6dDgsKRvCcG58d5c+J4 uUnWMSU6462wqbz5MER+SEQ4BCiFeRvhXfsoDCv+xx+7ovnkowXeF0Ztd1JTWHd8GUqPPEwpc= X-Received: by 2002:a05:6a00:4fcf:b0:84f:b01d:3693 with SMTP id d2e1a72fcca58-86169b6c458mr35685753b3a.15.1788862730973; Tue, 08 Sep 2026 03:18:50 -0700 (PDT) Message-ID: <130789b4-b7e8-4181-8aca-0ff4715a3323@gmail.com> Date: Tue, 8 Sep 2026 18:18:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server/docs/manager 0/3] add pvpanic device support To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260827103529.393388-1-wukaiyang@loongfans.cn> Content-Language: en-US From: Kaiyang Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7TNWQP5H2X3FZAOA7IPQHHTBAL62OSHL X-Message-ID-Hash: 7TNWQP5H2X3FZAOA7IPQHHTBAL62OSHL X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Dominik, This series of patches currently allow to display a yellow exclamation triangle on the web UI when a VM panics. I found the pve-manager CSS has already reserved the icon for the guest-panicked status. I think the idea of making it work with the HA stack is interesting. I will try to work on that, thanks for the suggestion! Best, Kaiyang On 2026-09-04 16:30, Dominik Csapak wrote: > Hi, > > high level question: > > with this series, the pvpanic device is added, but nothing on the other > side queries it? So what's the use case here? > > I think it could come in handy, but we should actually do something with > it ;) > > E.g. at least we could also set the panic handler in tandem: > > --action panic=none|shutdown|... > > e.g. a shutdown action on panic paired with our HA stack could > reboot the vm (didn't test though) > > On 8/27/26 12:35 PM, Kaiyang Wu wrote: >> This patchset adds pvpanic device support to QEMU virtual machines to >> provide extra virtual machine status (guest-panicked) when virtual >> machines panic. >> >> The pvpanic device can be implemented as an ISA device ('-device >> pvpanic') or as a PCI device ('-device pvpanic-pci') [0]. The ISA >> pvpanic device is only available on x86_64, and Linux VMs with kernel >>> =3.1 and <5.2 only support the ISA pvpanic device [1] [2]. Therefore, >> the patchset allows to choose between the two variants to fit different >> needs, and adds a documentation section to help picking the variant. >> >> [0]: https://www.qemu.org/docs/master/specs/pvpanic.html >> [1]: https://www.kernelconfig.io/CONFIG_PVPANIC >> [2]: https://www.kernelconfig.io/CONFIG_PVPANIC_PCI >> >> >> qemu-server: >> >> Kaiyang Wu (1): >>    qemuserver: add pvpanic device >> >>   src/PVE/API2/Qemu.pm      |  1 + >>   src/PVE/QemuServer.pm     | 19 +++++++++++++++++++ >>   src/PVE/QemuServer/PCI.pm |  1 + >>   3 files changed, 21 insertions(+) >> >> >> docs: >> >> Kaiyang Wu (1): >>    qm: add document section for the pvpanic device >> >>   qm.adoc | 29 +++++++++++++++++++++++++++++ >>   1 file changed, 29 insertions(+) >> >> >> manager: >> >> Kaiyang Wu (1): >>    ui: qemu: add pvpanic device support >> >>   www/manager6/Makefile                |  2 ++ >>   www/manager6/Utils.js                |  1 + >>   www/manager6/form/PvpanicSelector.js | 12 +++++++++ >>   www/manager6/qemu/Architecture.js    |  5 ++++ >>   www/manager6/qemu/HardwareView.js    | 15 +++++++++++ >>   www/manager6/qemu/PvpanicEdit.js     | 39 ++++++++++++++++++++++++++++ >>   6 files changed, 74 insertions(+) >>   create mode 100644 www/manager6/form/PvpanicSelector.js >>   create mode 100644 www/manager6/qemu/PvpanicEdit.js >> >