From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9BE09BF26B for ; Thu, 4 Jan 2024 14:03:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E4EDF0C4 for ; Thu, 4 Jan 2024 14:03:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 4 Jan 2024 14:03:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4186948CEA for ; Thu, 4 Jan 2024 14:03:07 +0100 (CET) Message-ID: <12f439d0-03ed-4af8-b4fd-b0cfed3a147b@proxmox.com> Date: Thu, 4 Jan 2024 14:03:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox VE development discussion , Fiona Ebner References: <20240104123847.29087-1-f.ebner@proxmox.com> From: Lukas Wagner In-Reply-To: <20240104123847.29087-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] fix #5074: notify: sendmail: smtp: fix mailto/mailto-user parameter deletion X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2024 13:03:38 -0000 On 1/4/24 13:38, Fiona Ebner wrote: > by doing a cbind of isCreate to the top-level widget so that cbind in > the nested widgets for deleteEmpty works. > > In the GUI, when a sendmail/smtp target is edited and either > 'Additional Recipients' or 'Recipients' is completely removed (only > possible if the other field contains a value), parameter deletion did > not work properly. After applying the changes, the old value would > still be in place. > I can confirm that this patch works as expected and fixes the issue. Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner -- - Lukas