From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C0AE01FF161 for ; Tue, 10 Sep 2024 14:53:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E36B235979; Tue, 10 Sep 2024 14:53:00 +0200 (CEST) Date: Tue, 10 Sep 2024 14:52:57 +0200 (CEST) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Proxmox VE development discussion , Fiona Ebner , Maximiliano Sandoval Message-ID: <1293421627.27309.1725972777366@webmail.proxmox.com> In-Reply-To: References: <20240812114411.155945-1-m.sandoval@proxmox.com> <20240812114411.155945-2-m.sandoval@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev67 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage v3 2/2] d/control: dependencies: add bzip2, gzip, lzop, zstd X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" > Fiona Ebner hat am 10.09.2024 14:24 CEST geschrieben: > Am 12.08.24 um 13:44 schrieb Maximiliano Sandoval: > > The decompressor_info method calls binaries provided by these packages > > so they are (alphabetically) added explicitly as dependencies. > > > > To avoid a build-time error > > > > E: libpve-storage-perl: depends-on-essential-package-without-using-version Depends: gzip > > > > the current minor version available in bullseye was set for gzip. > > > > Since I didn't get that error, I'm interested: what command are you > building with? Why the version for Bullseye? it's wrong in any case - gzip is Essential (installed on all Debian systems). you don't ever need a dependency (build or otherwise) for it. this is what lintian is trying to tell you - it's wrong to depend on gzip without a version constraint (and okay to use it without a dependency). *only* if you have a certain version requirement you need to add the dependency (with the proper version qualifier) to be able to encode that version requirement. > I guess many systems already have bzip2 installed, but do we really want > to require it for everybody? Or should we rather keep it optional (could > be a Recommends or Suggests dependency) and add a clean error if not > installed? I am not sure about *how* many (most dev machines yes, since it's build-essential and required by a lot of build-related packages ;)). it's only 124kB though, and libbz2-1.0 is always installed (it's transitively Essential via dpkg), so it doesn't pull in anything that isn't installed on all standard Debian-based systems anyway since it only depends on that and libc6. I don't really see a reason to use Recommends or Suggests here, even if bz2 compress isos are not that common. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel