From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8F3CB71ADC for ; Tue, 5 Oct 2021 08:10:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 81025237FD for ; Tue, 5 Oct 2021 08:10:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 11B1B237EE for ; Tue, 5 Oct 2021 08:10:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D54E44550D for ; Tue, 5 Oct 2021 08:10:01 +0200 (CEST) Message-ID: <1273bfa9-9782-5961-bf2a-150b4d487bf2@proxmox.com> Date: Tue, 5 Oct 2021 08:08:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20211004080225.346654-1-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211004080225.346654-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.225 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pveceph.pm, tools.pm] Subject: [pve-devel] applied: [PATCH v3 manager] ceph install: improve ceph install checks during installation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 06:10:02 -0000 On 04.10.21 10:02, Aaron Lauterer wrote: > Adding a flag file during the Ceph installation helps to cover the time > span in which the binary is already present but the installation not yet > done. > > The most noticeable effect is that the 'Next' button in the GUI will > only become active once the installation is actually finished and not > earlier. > > Signed-off-by: Aaron Lauterer > --- > > v2 -> v3 (thanks for the hints): > - calling it a flag and moving it to /run > - improve file opening / unlinking handling and showing errors > - adding more / improving comments > > v1 -> v3: check for plain file and not just existing file > > If the flag file is created before ceph is installed, there is no > effect. If it is created after Ceph has been installed, the user is > prompted by the install dialog once more, but apt will be done right > away. > > PVE/CLI/pveceph.pm | 12 ++++++++++++ > PVE/Ceph/Tools.pm | 4 +++- > 2 files changed, 15 insertions(+), 1 deletion(-) > > applied, thanks! I moved the actual file name into a helper method located in PVE::Ceph::Tools so that there's only a single source of truth for it. Plus some minor style nits.