From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7227060AF9 for ; Fri, 25 Sep 2020 10:35:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 66A0519143 for ; Fri, 25 Sep 2020 10:35:06 +0200 (CEST) Received: from mailpro.odiso.net (mailpro.odiso.net [89.248.211.110]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CABE119139 for ; Fri, 25 Sep 2020 10:35:05 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id A0C871BBA920; Fri, 25 Sep 2020 10:35:05 +0200 (CEST) Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YCU_9taQqIb2; Fri, 25 Sep 2020 10:35:05 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id 7F17A1BBA91D; Fri, 25 Sep 2020 10:35:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at mailpro.odiso.com Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NCCTF9F3wyWD; Fri, 25 Sep 2020 10:35:05 +0200 (CEST) Received: from mailpro.odiso.net (mailpro.odiso.net [10.1.31.111]) by mailpro.odiso.net (Postfix) with ESMTP id 6438D1BBA920; Fri, 25 Sep 2020 10:35:05 +0200 (CEST) Date: Fri, 25 Sep 2020 10:35:02 +0200 (CEST) From: Alexandre DERUMIER To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: <1270427221.1250623.1601022902478.JavaMail.zimbra@odiso.com> In-Reply-To: <0660b2c5-c733-7f3c-42ea-52425323fc1a@proxmox.com> References: <20200924084054.611548-1-aderumier@odiso.com> <20200924084054.611548-10-aderumier@odiso.com> <0660b2c5-c733-7f3c-42ea-52425323fc1a@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.12_GA_3866 (ZimbraWebClient - GC83 (Linux)/8.8.12_GA_3844) Thread-Topic: api2: increase version on apply/reload only Thread-Index: 6CgS/W2C/pbQEpU9JTINjrHAHi0JFQ== X-SPAM-LEVEL: Spam detection results: 0 AWL 0.413 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [controllers.pm, zones.pm, sdn.pm, vnets.pm, subnets.pm] Subject: Re: [pve-devel] [PATCH v8 pve-network 09/25] api2: increase version on apply/reload only X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2020 08:35:06 -0000 >>but how do you detect pending changes now? Well, the feature was mainly to detect pending change after reload. if a reload don't have applied correctly on a node, or if a node was down. I don't known if we want to display to user "pending config" changes, not y= et applied ? Befor this commit, It's displaying warning after any config change, and it's difficult to known if a problem occur after the reload. ----- Mail original ----- De: "Thomas Lamprecht" =C3=80: "Proxmox VE development discussion" , = "aderumier" Envoy=C3=A9: Vendredi 25 Septembre 2020 09:15:44 Objet: Re: [pve-devel] [PATCH v8 pve-network 09/25] api2: increase version = on apply/reload only On 24.09.20 10:40, Alexandre Derumier wrote:=20 > Signed-off-by: Alexandre Derumier =20 > ---=20 > PVE/API2/Network/SDN.pm | 3 +++=20 > PVE/API2/Network/SDN/Controllers.pm | 6 ------=20 > PVE/API2/Network/SDN/Subnets.pm | 3 ---=20 > PVE/API2/Network/SDN/Vnets.pm | 3 ---=20 > PVE/API2/Network/SDN/Zones.pm | 6 ------=20 > 5 files changed, 3 insertions(+), 18 deletions(-)=20 >=20 but how do you detect pending changes now?=20