From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id F1E9D1FF13B
	for <inbox@lore.proxmox.com>; Wed, 20 May 2026 16:05:30 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 95FC5AA62;
	Wed, 20 May 2026 16:05:27 +0200 (CEST)
Message-ID: <1226cfe8-f171-42eb-b9b8-3b46beb8659d@proxmox.com>
Date: Wed, 20 May 2026 16:05:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH network] ui: sdn: fabrics: drop dead disabled bindings
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260520125125.251655-1-g.goller@proxmox.com>
 <58f70cc4-2aa1-4e02-97f1-448868036948@proxmox.com>
Content-Language: en-US
In-Reply-To: <58f70cc4-2aa1-4e02-97f1-448868036948@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1779285907971
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.004 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: IRKHKUXDGKFKCW5ZHNYVPFTSBP22YAX6
X-Message-ID-Hash: IRKHKUXDGKFKCW5ZHNYVPFTSBP22YAX6
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 20.05.26 um 16:00 schrieb Thomas Lamprecht:
>> -                cbind: {
>> -                    disabled: '{!isCreate}',
>> -                    deleteEmpty: '{!isCreate}',
>> -                },
>> +                deleteEmpty: '{!isCreate}',
> using that template syntax only makes sense inside a bind (viewModel) or
> cbind (config bind), but you move them out of there, so this is not basically
> a literal string. Should be rather changed to a literal true or false or
> just dropped
> 
>>              });
>>          }
>>  
>> @@ -86,10 +83,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
>>                      name: 'ip6_prefix',
>>                      allowBlank: true,
>>                      skipEmptyText: true,
>> -                    cbind: {
>> -                        disabled: '{!isCreate}',
>> -                        deleteEmpty: '{!isCreate}',
>> -                    },
>> +                    deleteEmpty: '{!isCreate}',
> same here

ah, I think you wanted to just drop the "disabled: '{!isCreate}'," line?