From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A18EB962BF for ; Mon, 15 Apr 2024 13:36:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 876B58843 for ; Mon, 15 Apr 2024 13:36:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 15 Apr 2024 13:36:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 511A244AE2; Mon, 15 Apr 2024 13:36:08 +0200 (CEST) Date: Mon, 15 Apr 2024 13:36:07 +0200 (CEST) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Proxmox VE development discussion Cc: Daniel Krambrock Message-ID: <1201594547.6978.1713180967636@webmail.proxmox.com> In-Reply-To: References: <20240411080928.11334-1-krambrod@staff.uni-marburg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev61 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH firewall 1/1] fix #5335: sort cluster.fw entries in ALIASES section X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2024 11:36:09 -0000 > Daniel Krambrock via pve-devel hat am 11.04.2024 10:09 CEST geschrieben: Hi! for both this and the access-control patch, please add - *some* commit message (e.g., something like "stable sorting in XX config file allows tracking changes by checking into git or when using automation like ansible" would be enough. try to describe the *why*, rather than the *what* - the latter is usually obvious when looking at the diff, especially for such small patches ;)) - add your Signed-off-by trailer ("git commit --amend -s" should do the trick) note that you don't need to send a cover letter for single patches, those are just needed when you send bigger patch series where it makes sense to summarize all the patches to get a quick overview of the overall aim of the series. thanks! > --- > src/PVE/Firewall.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm > index 77cbaf4..81a8798 100644 > --- a/src/PVE/Firewall.pm > +++ b/src/PVE/Firewall.pm > @@ -3360,7 +3360,7 @@ my $format_aliases = sub { > my $raw = ''; > > $raw .= "[ALIASES]\n\n"; > - foreach my $k (keys %$aliases) { > + foreach my $k (sort keys %$aliases) { > my $e = $aliases->{$k}; > $raw .= "$e->{name} $e->{cidr}"; > $raw .= " # " . encode('utf8', $e->{comment}) > -- > 2.39.2