From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4B36C9065C for ; Thu, 22 Sep 2022 13:13:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F0B77E44 for ; Thu, 22 Sep 2022 13:13:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Sep 2022 13:13:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6EAA844556 for ; Thu, 22 Sep 2022 13:13:04 +0200 (CEST) Message-ID: <11872ccc-87bf-1b9b-e884-285018f93c78@proxmox.com> Date: Thu, 22 Sep 2022 13:13:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20220922110023.115994-1-f.ebner@proxmox.com> From: Fiona Ebner In-Reply-To: <20220922110023.115994-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.885 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.702 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH guest-common] replication: avoid "expected snapshot missing warning" when irrelevant X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2022 11:13:11 -0000 Am 22.09.22 um 13:00 schrieb Fiona Ebner: > Namely, when there are no snapshots at all on the volume, which also > is the case when the volume doesn't exist. This happens when a fresh > volume is added to an already replicated guest. The warning still triggers, when some other snapshot is added to the new disk before the replication runs (by taking a snapshot or via another replication). I'll send a v2 and print the warning only when there's actually another replication snapshot that would've been removed without the safeguard added by c0b2948. > > Fixes replication tests in pve-manager, which didn't like the additional > output. > > Fixes: c0b2948 ("replication: prepare: safeguard against removal if expected snapshot is missing")