From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8C7DF1FF17C for <inbox@lore.proxmox.com>; Wed, 28 May 2025 08:33:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC9912D3F7; Wed, 28 May 2025 08:34:09 +0200 (CEST) Date: Wed, 28 May 2025 08:33:36 +0200 (CEST) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> To: Denis Kanchev <denis.kanchev@storpool.com> Message-ID: <11746909.21389.1748414016786@webmail.proxmox.com> In-Reply-To: <CAHXTzuk7tYRJV_j=88RWc3R3C7AkiEdFUXi88m5qwnDeYDEC+A@mail.gmail.com> References: <mailman.538.1747833190.394.pve-devel@lists.proxmox.com> <1283184248.17536.1747895442851@webmail.proxmox.com> <857cbd6c-6866-417d-a71f-f5b5297bf09c@storpool.com> <1349127939.17705.1747902137180@webmail.proxmox.com> <CAHXTzuk7tYRJV_j=88RWc3R3C7AkiEdFUXi88m5qwnDeYDEC+A@mail.gmail.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev75 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] PVE child process behavior question X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> > Denis Kanchev <denis.kanchev@storpool.com> hat am 28.05.2025 08:13 CEST geschrieben: > > > Here is the task log > 2025-04-11 03:45:42 starting migration of VM 2282 to node 'telpr01pve05' (10.10.17.5) > 2025-04-11 03:45:42 starting VM 2282 on remote node 'telpr01pve05' > 2025-04-11 03:45:45 [telpr01pve05] Warning: sch_htb: quantum of class 10001 is big. Consider r2q change. > 2025-04-11 03:45:46 [telpr01pve05] Dump was interrupted and may be inconsistent. > 2025-04-11 03:45:46 [telpr01pve05] kvm: failed to find file '/usr/share/qemu-server/bootsplash.jpg' > 2025-04-11 03:45:46 start remote tunnel > 2025-04-11 03:45:46 ssh tunnel ver 1 > 2025-04-11 03:45:46 starting online/live migration on unix:/run/qemu-server/2282.migrate > 2025-04-11 03:45:46 set migration capabilities > 2025-04-11 03:45:46 migration downtime limit: 100 ms > 2025-04-11 03:45:46 migration cachesize: 4.0 GiB > 2025-04-11 03:45:46 set migration parameters > 2025-04-11 03:45:46 start migrate command to unix:/run/qemu-server/2282.migrate > 2025-04-11 03:45:47 migration active, transferred 152.2 MiB of 24.0 GiB VM-state, 162.1 MiB/s > ... > 2025-04-11 03:46:49 migration active, transferred 15.2 GiB of 24.0 GiB VM-state, 2.0 GiB/s > 2025-04-11 03:46:50 migration status error: failed > 2025-04-11 03:46:50 ERROR: online migrate failure - aborting > 2025-04-11 03:46:50 aborting phase 2 - cleanup resources > 2025-04-11 03:46:50 migrate_cancel > 2025-04-11 03:46:52 ERROR: migration finished with problems (duration 00:01:11) > TASK ERROR: migration problems okay, so no local disks involved.. not sure which process got killed then? ;) the state transfer happens entirely within the Qemu process, perl is just polling it to print the status, and that perl task worker is not OOM killed since it continues to print all the error handling messages.. > > that has weird implications with regards to threads, so I don't think that > > is a good idea.. > What you mean by that? Are any threads involved? not intentionally, no. the issue is that the whole "pr_set_deathsig" machinery works on the thread level, not the process level for historical reasons. so it actually would kill the child if the thread that called pr_set_deathsig exits.. I think we do want to improve how run_command handles the parent disappearing. but it's not that straight-forward to implement in a race-free fashion (in Perl). _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel