From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 66CB91FF16B for <inbox@lore.proxmox.com>; Thu, 20 Feb 2025 15:04:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6FFB41397B; Thu, 20 Feb 2025 15:04:25 +0100 (CET) Message-ID: <11446e27-9375-49b9-a0ac-82efabe36416@proxmox.com> Date: Thu, 20 Feb 2025 15:04:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Daniel Kral <d.kral@proxmox.com> References: <20250211160825.254167-1-d.kral@proxmox.com> <20250211160825.254167-10-d.kral@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20250211160825.254167-10-d.kral@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v2 04/15] api: remove unused size variable in check_storage_access X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 11.02.25 um 17:08 schrieb Daniel Kral: > Remove variable `$size`, which is not used here and likely a copy-paste > redundancy from the `create_disks` subroutine. > > Signed-off-by: Daniel Kral <d.kral@proxmox.com> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com> > --- > changes since v1: > - new! > > PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 370036b8..5ac61aa5 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -148,7 +148,7 @@ my $check_storage_access = sub { > } elsif ($isCDROM && ($volid eq 'cdrom')) { > $rpcenv->check($authuser, "/", ['Sys.Console']); > } elsif (!$isCDROM && ($volid =~ $PVE::QemuServer::Drive::NEW_DISK_RE)) { > - my ($storeid, $size) = ($2 || $default_storage, $3); > + my $storeid = $2 || $default_storage; > die "no storage ID specified (and no default storage)\n" if !$storeid; > $rpcenv->check($authuser, "/storage/$storeid", ['Datastore.AllocateSpace']); > my $scfg = PVE::Storage::storage_config($storecfg, $storeid); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel