From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 75E8284B6A for ; Wed, 15 Dec 2021 15:56:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C80413EDF for ; Wed, 15 Dec 2021 15:56:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DFFF813ED4 for ; Wed, 15 Dec 2021 15:56:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B3469451ED for ; Wed, 15 Dec 2021 15:56:25 +0100 (CET) Message-ID: <10f1c6bd-be42-5db9-2570-e9f5f4cda968@proxmox.com> Date: Wed, 15 Dec 2021 15:56:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-US To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20211214101912.3509825-1-f.gruenbichler@proxmox.com> <20211214101912.3509825-2-f.gruenbichler@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211214101912.3509825-2-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH cluster 2/2] clusterlog: fix segfault / wrong iteration bounds X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2021 14:56:56 -0000 On 14.12.21 11:19, Fabian Gr=C3=BCnbichler wrote: =2E.. > note that the actual sizes of the entries are not relevant, the > requirements are: > - entry before last wrap-around must be big enough that entry of curren= t > index can overtake it without another wrap-around > - method that does iteration must be called before next wrap-around >=20 > the fix is obviously trivial once the issue became apparent - when > wrapping around during iteration, additionally check that we are not > jumping across the red zone into already invalidated parts of data. >=20 > clusterlog_merge is technically not affected since it aborts before a > wrap-around anyway, but it doesn't hurt to have the checks consistently= > in case this ever changes. >=20 > thanks to @kev1904 on our community forums for reporting and providing = the data > to nail the cause down fast! >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- > data/src/logger.c | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) >=20 > applied, many thanks!!