From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BD5F671836 for ; Thu, 19 May 2022 09:37:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A9FF74EB1 for ; Thu, 19 May 2022 09:36:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D24EA4EA4 for ; Thu, 19 May 2022 09:36:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9B5DD436EA for ; Thu, 19 May 2022 09:36:45 +0200 (CEST) Message-ID: <108103d5-6508-676d-fceb-50b9fbe75d6b@proxmox.com> Date: Thu, 19 May 2022 09:36:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Proxmox VE development discussion , Fabian Ebner References: <20220517082949.60472-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220517082949.60472-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [gitlab.com, proxmox.com] Subject: [pve-devel] applied: [PATCH qemu] add revert to work around performance regression when backing up large RBD disk X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2022 07:37:16 -0000 Am 5/17/22 um 10:29 schrieb Fabian Ebner: > resulting in QMP timeouts and very slow backups. The plan is to figure > out (ideally together with upstream) a way to make the implementation > of bdrv_co_block_status for RBD more efficient. But for now, revert > the problematic change as a stop-gap measure. > > Upstream bug report: > https://gitlab.com/qemu-project/qemu/-/issues/1026 > > Forum threads: > https://forum.proxmox.com/threads/109272/ > https://forum.proxmox.com/threads/109448/ > https://forum.proxmox.com/threads/101334/ (partially) > > Signed-off-by: Fabian Ebner > --- > > I simply removed the other two patches already fixing the offending > commit from the "series" file, to make it less likely that we forget > to re-add them once we revert the revert and to reduce the git diff. > Hope that is ok. > > ...k-rbd-implement-bdrv_co_block_status.patch | 161 ++++++++++++++++++ > debian/patches/series | 3 +- > 2 files changed, 162 insertions(+), 2 deletions(-) > create mode 100644 debian/patches/pve/0053-Revert-block-rbd-implement-bdrv_co_block_status.patch > > applied, thanks!