public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH cluster] datacenter config: document that the migration network affects replications
Date: Mon, 2 Jun 2025 14:56:24 +0200	[thread overview]
Message-ID: <0f82502b-c991-45ad-8535-c4e25fc0870e@proxmox.com> (raw)
In-Reply-To: <20250519122537.324793-1-m.sandoval@proxmox.com>

Am 19.05.25 um 14:25 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index a3db78e..205b784 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -44,7 +44,7 @@ my $migration_format = {
>  	optional => 1,
>  	type => 'string', format => 'CIDR',
>  	format_description => 'CIDR',
> -	description => "CIDR of the (sub) network that is used for migration."
> +	description => "CIDR of the (sub) network that is used for migration and replication."
>      },
>  };
>  

good to describe the status quo, but that status is not really ideal, might
be worth to add a dedicated setting for this outside of the "migration"
property. Upcoming PVE 9 would be a good choice for this, as then we could
output a notice for the case that the migration network is configured and
there are existing replication jobs defined,


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-06-02 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 12:25 Maximiliano Sandoval
2025-05-20 12:34 ` [pve-devel] applied: " Fiona Ebner
2025-06-02 12:56 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f82502b-c991-45ad-8535-c4e25fc0870e@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal