From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EB63C1FF15C for ; Fri, 3 Oct 2025 17:02:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 673B2743B; Fri, 3 Oct 2025 17:02:27 +0200 (CEST) Message-ID: <0f0abadd-bd3a-41e2-a604-dbbb935961fd@proxmox.com> Date: Fri, 3 Oct 2025 17:01:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20250408122710.1164112-1-a.lauterer@proxmox.com> From: Aaron Lauterer In-Reply-To: <20250408122710.1164112-1-a.lauterer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759503689614 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server, manager v7 0/4] fix #1926 autodetect xtermjs or novnc for VM console X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" sent a v8 https://lore.proxmox.com/pve-devel/20251003150045.3359961-1-a.lauterer@proxmox.com/T/#m5f17dbd96d13e94e829e44992c809d4569bc736e On 2025-04-08 14:27, Aaron Lauterer wrote: > Sorry for the noise, after the feedback from Fiona on v6 and some > off-list discussion, we decided to improve the backend part by moving > the "default" logic out of `get_vga_properties` and move it into a > separate public `get_default_vga_type` function. This way we can leave > all the other functions private to the QemuServer.pm module. > > > We add a new property in the VM status/current API result that includes > the display configurtion of the VM. This way we can check in the > frontend what to do with it. > > I chose a nested return value, as that makes it easier to add/move > additional display properties into it. > > Patch 1/4 moves the default display logic into its own public function > > Patch 2/4 adds the new display property. If not explicitly set in the VM > config, it will return the default value. > > Patch 3/4 implements the changes in the UI. The final result isn't > really a lot simpler on the UI side than in V4 where we had the extra > API call to the VM's config directly. Because we still need to wait for > the API call to finish when initially navigating to the VM. But we have > one fewer call. > > Patch 4/4 then introduces some changes to make loading of the console > faster if we just navigate in the submenu of a VM itself where we > already have the current status of a VM already cached. > > Changes from > v6: backend only: create new `get_default_vga_type` function. > v5: implement suggestions: > > * use get_vga_properties for default VGA > * UI: use helper to determine if serial display > > qemu-server: Aaron Lauterer (2): > QemuServer: add new public get_default_vga_type function > api: status/current: add display property > > PVE/API2/Qemu.pm | 13 +++++++++++++ > PVE/QemuServer.pm | 29 ++++++++++++++++++++++------- > 2 files changed, 35 insertions(+), 7 deletions(-) > > > manager: Aaron Lauterer (2): > fix #1926 ui: vm console: autodetect novnc or xtermjs > ui: console: check on activate if display info for VMs is present > > www/manager6/Utils.js | 4 +++ > www/manager6/VNCConsole.js | 60 ++++++++++++++++++++++++++----------- > www/manager6/qemu/Config.js | 7 ++++- > 3 files changed, 53 insertions(+), 18 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel