From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A6B611FF183 for ; Wed, 4 Jun 2025 10:59:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CDA3C379D5; Wed, 4 Jun 2025 10:59:41 +0200 (CEST) Message-ID: <0ee8dfc6-9b5f-4961-9725-b0d50ab82bc6@proxmox.com> Date: Wed, 4 Jun 2025 10:59:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: pve-devel@lists.proxmox.com References: <20250528110428.72358-1-a.abraham@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250528110428.72358-1-a.abraham@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox_login_manager] ui: Changed "sites" to "hosts". X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 5/28/25 13:04, Alexander Abraham wrote: > Changed the "Available Sites" text inside the added PVE > hosts view to "Available Hosts" because "Sites" is a bit > odd. > I disagree. While it could happen that users add all hosts to their app, every entry in the app is basically a connection to a cluster, which can contain multiple hosts. I know we don't have a fallback connection mechanism for other hosts yet, but IMO 'Sites' / 'Available Sites' still fit better as we don't list all hosts from all clusters here. (The same holds for the other patch for pve_flutter_frontend) > Signed-off-by: Alexander Abraham > --- > lib/proxmox_login_selector.dart | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/proxmox_login_selector.dart b/lib/proxmox_login_selector.dart > index fb1218b..7fc0068 100644 > --- a/lib/proxmox_login_selector.dart > +++ b/lib/proxmox_login_selector.dart > @@ -127,7 +127,7 @@ class _ProxmoxLoginSelectorState extends State { > const Padding( > padding: EdgeInsets.all(12.0), > child: Text( > - 'Available Sites', > + 'Available Hosts', > style: TextStyle( > fontSize: 18, > fontWeight: FontWeight.bold, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel