public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH proxmox_login_manager] ui: Changed "sites" to "hosts".
@ 2025-05-28 11:04 Alexander Abraham
  2025-06-04  8:59 ` Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Abraham @ 2025-05-28 11:04 UTC (permalink / raw)
  To: pve-devel

Changed the "Available Sites" text inside the added PVE
hosts view to "Available Hosts" because "Sites" is a bit
odd.

Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
---
 lib/proxmox_login_selector.dart | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/proxmox_login_selector.dart b/lib/proxmox_login_selector.dart
index fb1218b..7fc0068 100644
--- a/lib/proxmox_login_selector.dart
+++ b/lib/proxmox_login_selector.dart
@@ -127,7 +127,7 @@ class _ProxmoxLoginSelectorState extends State<ProxmoxLoginSelector> {
               const Padding(
                 padding: EdgeInsets.all(12.0),
                 child: Text(
-                  'Available Sites',
+                  'Available Hosts',
                   style: TextStyle(
                     fontSize: 18,
                     fontWeight: FontWeight.bold,
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pve-devel] [PATCH proxmox_login_manager] ui: Changed "sites" to "hosts".
  2025-05-28 11:04 [pve-devel] [PATCH proxmox_login_manager] ui: Changed "sites" to "hosts" Alexander Abraham
@ 2025-06-04  8:59 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2025-06-04  8:59 UTC (permalink / raw)
  To: pve-devel

On 5/28/25 13:04, Alexander Abraham wrote:
> Changed the "Available Sites" text inside the added PVE
> hosts view to "Available Hosts" because "Sites" is a bit
> odd.
> 

I disagree. While it could happen that users add all hosts to their app,
every entry in the app is basically a connection to a cluster, which can contain
multiple hosts.

I know we don't have a fallback connection mechanism for other hosts yet, but
IMO  'Sites' / 'Available Sites' still fit better as we don't list all
hosts from all clusters here.

(The same holds for the other patch for pve_flutter_frontend)

> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
>   lib/proxmox_login_selector.dart | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/proxmox_login_selector.dart b/lib/proxmox_login_selector.dart
> index fb1218b..7fc0068 100644
> --- a/lib/proxmox_login_selector.dart
> +++ b/lib/proxmox_login_selector.dart
> @@ -127,7 +127,7 @@ class _ProxmoxLoginSelectorState extends State<ProxmoxLoginSelector> {
>                 const Padding(
>                   padding: EdgeInsets.all(12.0),
>                   child: Text(
> -                  'Available Sites',
> +                  'Available Hosts',
>                     style: TextStyle(
>                       fontSize: 18,
>                       fontWeight: FontWeight.bold,



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-04  8:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-28 11:04 [pve-devel] [PATCH proxmox_login_manager] ui: Changed "sites" to "hosts" Alexander Abraham
2025-06-04  8:59 ` Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal