From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH proxmox_login_manager] ui: Changed "sites" to "hosts".
Date: Wed, 4 Jun 2025 10:59:38 +0200 [thread overview]
Message-ID: <0ee8dfc6-9b5f-4961-9725-b0d50ab82bc6@proxmox.com> (raw)
In-Reply-To: <20250528110428.72358-1-a.abraham@proxmox.com>
On 5/28/25 13:04, Alexander Abraham wrote:
> Changed the "Available Sites" text inside the added PVE
> hosts view to "Available Hosts" because "Sites" is a bit
> odd.
>
I disagree. While it could happen that users add all hosts to their app,
every entry in the app is basically a connection to a cluster, which can contain
multiple hosts.
I know we don't have a fallback connection mechanism for other hosts yet, but
IMO 'Sites' / 'Available Sites' still fit better as we don't list all
hosts from all clusters here.
(The same holds for the other patch for pve_flutter_frontend)
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
> lib/proxmox_login_selector.dart | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/proxmox_login_selector.dart b/lib/proxmox_login_selector.dart
> index fb1218b..7fc0068 100644
> --- a/lib/proxmox_login_selector.dart
> +++ b/lib/proxmox_login_selector.dart
> @@ -127,7 +127,7 @@ class _ProxmoxLoginSelectorState extends State<ProxmoxLoginSelector> {
> const Padding(
> padding: EdgeInsets.all(12.0),
> child: Text(
> - 'Available Sites',
> + 'Available Hosts',
> style: TextStyle(
> fontSize: 18,
> fontWeight: FontWeight.bold,
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-06-04 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 11:04 Alexander Abraham
2025-06-04 8:59 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ee8dfc6-9b5f-4961-9725-b0d50ab82bc6@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox