From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 56FDF90CFE; Fri, 23 Sep 2022 12:29:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 314DB23EE9; Fri, 23 Sep 2022 12:28:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Fri, 23 Sep 2022 12:28:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 757AE444F7; Fri, 23 Sep 2022 12:28:30 +0200 (CEST) Message-ID: <0cec4592-8711-a9fd-09a7-6ab0028b58fc@proxmox.com> Date: Fri, 23 Sep 2022 12:28:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 Content-Language: en-GB To: Proxmox Backup Server development discussion , Matthias Heiserer , pve-devel@lists.proxmox.com References: <20220721104559.302270-1-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220721104559.302270-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [pbs-devel] [PATCH proxmox-backup] fix #4165: SMART: add raw field X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2022 10:29:01 -0000 Am 21/07/2022 um 12:45 schrieb Matthias Heiserer: > This makes it consistent with the naming scheme in PVE/GUI. > Keep value for API stability reasons, and remove it in next major version. > > Signed-off-by: Matthias Heiserer > --- > src/tools/disks/smart.rs | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > applied, with Dominik's T-b/R-b and a small follow up (see below), thanks! > diff --git a/src/tools/disks/smart.rs b/src/tools/disks/smart.rs > index 3738cdfd..787971e9 100644 > --- a/src/tools/disks/smart.rs > +++ b/src/tools/disks/smart.rs > @@ -25,8 +25,11 @@ pub enum SmartStatus { > pub struct SmartAttribute { > /// Attribute name > name: String, > - /// Attribute raw value > + // fixme remove value in major release Please capitalize FIXME, as that way most editors will highlight it by default, additionally include the specific major release this should be removed. I changed it to: // FIXME: remove value with next major relase (PBS 3.0)