From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CD348CA33 for ; Mon, 10 Jul 2023 10:20:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9BCEC3C2D9 for ; Mon, 10 Jul 2023 10:20:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 10 Jul 2023 10:20:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B602C428B2 for ; Mon, 10 Jul 2023 10:20:13 +0200 (CEST) Message-ID: <0c6d1b85-ba97-de7a-12f5-4108f1070d2c@proxmox.com> Date: Mon, 10 Jul 2023 10:20:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: Fiona Ebner To: pve-devel@lists.proxmox.com Reply-To: Proxmox VE development discussion References: <20230710075825.15882-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20230710075825.15882-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server 1/2] qmeventd: improve getting vmid from PID in presence of legacy cgroup entries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2023 08:20:45 -0000 Am 10.07.23 um 09:58 schrieb Fiona Ebner: > On a hybrid cgroup system, the /proc//cgroup file usually looks > like: > >> 13:pids:/qemu.slice/110.scope >> 12:perf_event:/ >> 11:devices:/qemu.slice >> 10:misc:/ >> 9:hugetlb:/ >> 8:freezer:/ >> 7:cpu,cpuacct:/qemu.slice/110.scope >> 6:memory:/qemu.slice/110.scope >> 5:rdma:/ >> 4:cpuset:/ >> 3:blkio:/qemu.slice >> 2:net_cls,net_prio:/ >> 1:name=systemd:/qemu.slice/110.scope >> 0::/qemu.slice/110.scope > > but after 'umount /sys/fs/cgroup/pids' or for other reasons, it could > happen that an entry like '11:devices:/qemu.slice' is the first to > match the '/qemu.slice' part, which previously made the code expect to > find the VMID. > > To improve detection, as a first step, match the trailing slash too. > > Reported in the community forum: > https://forum.proxmox.com/threads/129320/post-571654 > > Signed-off-by: Fiona Ebner I'll send a v2 with a bit more. Sorry for the noise.