From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2B56920EC91 for ; Tue, 30 Apr 2024 10:14:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE6811E37A; Tue, 30 Apr 2024 10:14:16 +0200 (CEST) Message-ID: <0c6b8981-11cf-4f5e-8567-25c0f8e25ffe@proxmox.com> Date: Tue, 30 Apr 2024 10:14:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Wolfgang Bumiller References: <20240430075343.39367-1-w.bumiller@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240430075343.39367-1-w.bumiller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 30.04.24 um 09:53 schrieb Wolfgang Bumiller: > This prevents importing from vmdks with whitespaces in file names. > Further, some operations that include file sizes (like listing disks) > would potentially fail entirely if a custom disk with a badly name > backing device exists in a VM images directory since they don't expect > this. Specifically, since we don't necessarily know the actual naming > scheme of the current storage in the plain Plugin.pm version, we don't > check the full name anyway, so why bother with whitespaces... > > See-also: https://forum.proxmox.com/threads/new-import-wizard-available-for-migrating-vmware-esxi-based-virtual-machines.144023/page-16#post-658697 > Signed-off-by: Wolfgang Bumiller > --- > src/PVE/Storage/Plugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm > index 22a9729..683190b 100644 > --- a/src/PVE/Storage/Plugin.pm > +++ b/src/PVE/Storage/Plugin.pm > @@ -982,7 +982,7 @@ sub file_size_info { > $used = int($used); > ($format) = ($format =~ /^(\S+)$/) or die "format '$format' includes whitespace\n"; # untaint > if (defined($parent)) { > - ($parent) = ($parent =~ /^(\S+)$/) or die "parent '$parent' includes whitespace\n"; # untaint > + ($parent) = ($parent =~ /^(\S+)$/); # untaint > } > return wantarray ? ($size, $format, $used, $parent, $st->ctime) : $size; > } So the returned $parent will now just be undef if it contains whitespaces, even though there is a parent. Can't that cause issues further down the line? If it's fine, a comment with the rationale would be nice. Or should we rather allow whitespaces while matching and return it properly? Or are there any issues with proper escaping then? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel