From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id CA9891FF0E5 for ; Wed, 15 Jul 2026 11:04:53 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7D84C213EB; Wed, 15 Jul 2026 11:04:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784106277; x=1784711077; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1rv2BSYCAFGM9Oyw29mxULKXZ31hijSRI6ESWPIoyhk=; b=PqMGBk+ygE8crhYXLrDHCADRMmxvNDNXa+2qAM+F/6zjhrOlJJUQZ8qwmnYeUdZOJX FjM0DS5ymLfyUCTNSP0P3WOMOaJRHRQgmyOh3sFNH1X4Px0YNnr9fQ/mWN+HIcrG6d1v /vrGuEHFAHNmrXCkd8IUA50edYBTHijx/BFHY4pfQVUK+7rHa2/mRwiBED8GkXvjUvRv GHVhCw7023xKCS+p2xhVTui8UD9Kj2Tzt3XAyebL9r2/UTBFs5PxFaXuIyJwsA9WoCL9 Res7a7vbcRxCjXoeCuoIWO0ZfVT/NSS0t7rK+dfxXNLAP4e0nkjzH+oja8hxr9Bum5nu 73eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784106277; x=1784711077; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1rv2BSYCAFGM9Oyw29mxULKXZ31hijSRI6ESWPIoyhk=; b=n4+AoABDe79BJ7bZVje7A1NJwinPHxX/ziIuRWpGhVepn4fTmDWK7O21m0t4R5rj2t UoJUAn7D0IYFPcZkLYOzAqUwAnbxRjhTRJxdFgp5XdrdMf8ByqKpXdahkf7YedhjBicq x0ogG2hVlj9OA8FJ/uI6qLMQvUHbQ52XAs2zN+sYtnunr6pwyyZsQu1BL7M55noe8Tgf 0ETZIqT/I5Is4DjjKj8iTIihXxnX3tkpBq6zmlYT5T2wZX8UvvFP7vujF8sMFjlmseyv mHSNOe3WUv69AbSCd3oYP7ejvioIMvy1t+KJaGQYIZtC21DWci6B/rc0mhEvCJudUVZR pcXA== X-Forwarded-Encrypted: i=1; AHgh+RpyeAUfE/DA9Lj8/f/IZrKOR6rQEQtRCukDk9gO+fJYGnryXbhHpHueEAjf63lHWksv9wAcm4bUs4Y=@lists.proxmox.com X-Gm-Message-State: AOJu0YxP7weQXJvn5D8Be2SITjyjgl7Rzrx7iYIUGXQk1Vka/rpoHZKs 7ahC95limChkdVBzeB371Qz90cRtxLcTnI/OA0KduDuYTMAf4bYMIiqV X-Gm-Gg: AfdE7clok73CUSbVmgM8P1WWh2VL8+HrAoEoIOYI2X+3t3jX1k9KBSNilL6hUZDD4xf QE3hmU/DZohhPbtG0HYteqGMMGf9/ZaIEJN+/Z/YPkVMfhjhvwgf2iGll0wQFZ3wKjig0D1lG2l DCVGpu669w42G683/rT2LQCgq3OjB6nbYyyJcXaCE3Gmq1zBk6Ja7H/1Sj5mh7+4ku+98klwVXW ryaatZkr6fu6wvh/rznTbieHwxEOJ8qbLY7J1aKF9ut3baXI7sUk3tMK3ME/xUyPDov86fuLJwq Db1OtpZHguqQDII0OrjtuvuhRCK4Dc0zLx/vmYytv/TpPxsZhFWHgSxzAiep848EnO4c1IZyNbu fWfNu513grVUFD5cypU/9B6VsmvIrsTc1LdyL8+o0ToJfogDJFXC0UiFVXwZAUFQ+y2paCtoWxy oWFyvm1OvmMCAOM7DK4TjLdkMB0e/aQ9KR X-Received: by 2002:a17:902:e88b:b0:2ca:1b97:70c5 with SMTP id d9443c01a7336-2ce9eae2dedmr169647385ad.4.1784106276648; Wed, 15 Jul 2026 02:04:36 -0700 (PDT) Message-ID: <0c3096fd-d398-4b14-923f-8d7941a6df93@gmail.com> Date: Wed, 15 Jul 2026 17:04:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-container] setup: openeuler: use network scripts to setup network To: David Riley , pve-devel@lists.proxmox.com References: <20260706121458.73398-1-wukaiyang@loongfans.cn> Content-Language: en-US From: Kaiyang Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZN4FXB7EGMMKGJKQQTKBU67EB53RVQYC X-Message-ID-Hash: ZN4FXB7EGMMKGJKQQTKBU67EB53RVQYC X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-07-14 16:09, David Riley wrote: > Please split this up into two commits one focusing on the typo and the > other > one fixing the issue. > > This does not work. It does allow the container to be created, but > it won't set a configured static IP address correctly. > I tested it with: > > cat /etc/os-release > NAME="openEuler" > VERSION="24.03 (LTS-SP4)" > > I think it should be: > $self->setup_network_with_network_scripts($conf); > instead. I will address these issues in v2. > But I think we need to take this fix in a different direction altogether. > > Overriding setup_network here to force legacy network scripts > bypasses the root cause of the issue. The actual bug is that CentOS.pm > crashes > when /etc/redhat-release is missing, which prevents it from choosing the > correct network setup. > > Hardcoding the legacy fallback here should not be the way to go forward > here. > OpenEuler already includes and prefers NetworkManager, as listed in the > linuxcontainers.org yaml you linked [0]. Forcing legacy network scripts > is not a future proof solution, as it already has been deprecated upstream > (see: RHEL 8 [1]). > > So what this patch needs is something similar to the version check in > CentOS.pm > using the alternative path /etc/os-release instead. > > [0] https://github.com/lxc/lxc-ci/ > blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L250 > [1] https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/ > html/8.4_release_notes/deprecated_functionality#deprecated- > functionality_networking The upstream yaml still prefers legacy network scripts on x86_64 and aarch64 [0], despite preferring NetworkManager on armhfp [1]. [0] https://github.com/lxc/lxc-ci/blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L245-L247 [1] https://github.com/lxc/lxc-ci/blob/7a61e7539f0009ab458661628a34267cbfc288a7/images/openeuler.yaml#L256-L257 Best, Kaiyang