From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A7E031FF163 for ; Thu, 7 Nov 2024 14:28:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 69165304D4; Thu, 7 Nov 2024 14:29:03 +0100 (CET) Message-ID: <0c229677-34ac-4586-9342-0fec4d4586c0@proxmox.com> Date: Thu, 7 Nov 2024 14:28:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Daniel Kral To: Fiona Ebner , Proxmox VE development discussion References: <20241031140622.153169-1-d.kral@proxmox.com> <26371bea-2bd7-42d7-807a-21f2263073c4@proxmox.com> Content-Language: en-US In-Reply-To: <26371bea-2bd7-42d7-807a-21f2263073c4@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: cloudinit: disallow unprivileged users to regenerate images X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/4/24 13:02, Fiona Ebner wrote: > Since those users can already use the cloudinit_update endpoint (just > not via UI) and thus effectively don't need "VM.Config.CDROM", I think > it's better to change the UI to use that endpoint as well. > > The endpoint was added here [0] and the switch in the UI was already > proposed [1] as part of that but it seems never applied. > > [0]: > https://lore.proxmox.com/pve-devel/20220622115206.3295425-1-aderumier@odiso.com/ > > [1]: > https://lore.proxmox.com/pve-devel/20220622141335.3616129-2-aderumier@odiso.com/ Thanks for pointing that out! I also think that it would be a better solution. I've already applied the UI patches locally, but since the cloudinit-related API endpoint's have been changed significantly since then, I will update those parts of the patch and send it anew as a v2 with an added Originally-by trailer. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel