From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id DB1CA1FF185
	for <inbox@lore.proxmox.com>; Mon, 17 Nov 2025 17:43:33 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 3206D1F993;
	Mon, 17 Nov 2025 17:43:37 +0100 (CET)
Message-ID: <0bec9cbe-7247-4b04-9fb8-e1c5f0886aa2@proxmox.com>
Date: Mon, 17 Nov 2025 17:43:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Markus Frank <m.frank@proxmox.com>
References: <20251117162819.465530-1-m.frank@proxmox.com>
 <20251117162819.465530-2-m.frank@proxmox.com>
 <1e5dc1f7-539f-46c3-b79b-de186a3ea89d@proxmox.com>
Content-Language: en-US
In-Reply-To: <1e5dc1f7-539f-46c3-b79b-de186a3ea89d@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1763397784923
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.017 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server v1 1/3] vga: allow
 live-migration with clipboard
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Am 17.11.25 um 5:41 PM schrieb Fiona Ebner:
> Am 17.11.25 um 5:28 PM schrieb Markus Frank:
>> The live-migration feature now works with qemu's upstream commit:
>> 5d56bff11e ("ui/vdagent: add migration support")
>>
>> Signed-off-by: Markus Frank <m.frank@proxmox.com>
>> ---
>>  src/PVE/API2/Qemu.pm   | 5 -----
>>  src/PVE/QemuMigrate.pm | 5 -----
>>  src/PVE/QemuServer.pm  | 2 +-
>>  3 files changed, 1 insertion(+), 11 deletions(-)
>>
>> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
>> index 02f5caec..314b6a48 100644
>> --- a/src/PVE/API2/Qemu.pm
>> +++ b/src/PVE/API2/Qemu.pm
>> @@ -5267,11 +5267,6 @@ __PACKAGE__->register_method({
>>          my ($local_resources, $mapped_resources, $missing_mappings_by_node) =
>>              PVE::QemuMigrate::Helpers::check_local_resources($vmconf, $res->{running}, 1);
>>  
>> -        my $vga = PVE::QemuServer::parse_vga($vmconf->{vga});
>> -        if ($res->{running} && $vga->{'clipboard'} && $vga->{'clipboard'} eq 'vnc') {
>> -            push $local_resources->@*, "clipboard=vnc";
>> -        }
> 
> I suppose this depends on having machine version >= 10.1, or? (In any
> case QEMU binary version >= 10.1 but that is implied by machine version >= 10.1)
Sorry, there was an accidental quote here by '>' ending up at the
beginning of the line ;)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel