From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2F16E715CB for ; Fri, 11 Jun 2021 11:29:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1C95AF736 for ; Fri, 11 Jun 2021 11:28:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5FF02F727 for ; Fri, 11 Jun 2021 11:28:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 248F742EAB for ; Fri, 11 Jun 2021 11:28:57 +0200 (CEST) Message-ID: <0ac6276d-0cde-98da-38b8-5d64d4ae4937@proxmox.com> Date: Fri, 11 Jun 2021 11:28:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20210609135415.3361404-1-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210609135415.3361404-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.939 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfspoolplugin.pm] Subject: Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes" X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jun 2021 09:29:28 -0000 On 09.06.21 15:54, Aaron Lauterer wrote: > https://github.com/zfsonlinux/zfs/issues/8541 is solved and part of > openzfs 2.0 with [0]. Since we ship only ZFS 2.0 with PVE 7 we should be > okay to remove our workaround > > [0] https://github.com/openzfs/zfs/commit/47c9299fcc9e5fb91d0b1636bfacc03bd3e98439 > > This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15. > --- > PVE/Storage/ZFSPoolPlugin.pm | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm > index 2e2abe3..f719f42 100644 > --- a/PVE/Storage/ZFSPoolPlugin.pm > +++ b/PVE/Storage/ZFSPoolPlugin.pm > @@ -313,12 +313,7 @@ sub zfs_get_pool_stats { > > sub zfs_create_zvol { > my ($class, $scfg, $zvol, $size) = @_; > - > - # always align size to 1M as workaround until > - # https://github.com/zfsonlinux/zfs/issues/8541 is solved > - my $padding = (1024 - $size % 1024) % 1024; > - $size = $size + $padding; > - > + above + line introduces a trailing whitespace error, please avoid that. Can you please resend with that fixed and Fabi's T-b tag added? > my $cmd = ['create']; > > push @$cmd, '-s' if $scfg->{sparse}; >