From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7A39990F90 for ; Tue, 31 Jan 2023 18:02:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6241C271C2 for ; Tue, 31 Jan 2023 18:02:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 31 Jan 2023 18:02:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 15DF045708 for ; Tue, 31 Jan 2023 18:02:54 +0100 (CET) Message-ID: <0aa4574c-1716-6e07-dff6-ecf9b53e64c4@proxmox.com> Date: Tue, 31 Jan 2023 18:02:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Dominik Csapak References: <20230127101436.2200018-1-d.csapak@proxmox.com> <20230127101436.2200018-3-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230127101436.2200018-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -1.351 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager 1/1] ui: ComboBoxSetStoreNode: don't hide the picker when clicking the toolbar X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2023 17:02:55 -0000 Am 27/01/2023 um 11:14 schrieb Dominik Csapak: > When clicking the toolbar of the ComboGrid, the combobox loses focus, > and instantly hides the picker. > > To prevent that, we keep track of the mousedown event on the toolbar > (which happily comes before the focusLeave event), and prevent the > focusLeave propagation in that case. > > Then on mouseup, we focus the combobox again, so that the nexct > focusLeave can trigger again. > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/ComboBoxSetStoreNode.js | 30 +++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > applied, thanks!