From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5A59C98780 for ; Mon, 9 Oct 2023 12:47:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F0F216210 for ; Mon, 9 Oct 2023 12:46:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 9 Oct 2023 12:46:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 75BB54480B for ; Mon, 9 Oct 2023 12:46:31 +0200 (CEST) Message-ID: <0a80e621-7f96-474e-9ed7-573b7c4bd46b@proxmox.com> Date: Mon, 9 Oct 2023 12:46:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , hd References: <20231009093823.74910-1-h.duerr@proxmox.com> <20231009093823.74910-2-h.duerr@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <20231009093823.74910-2-h.duerr@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, user.name] Subject: Re: [pve-devel] [PATCH proxmox-i18n 1/1] update German translation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2023 10:47:03 -0000 Hello Hannes, please configure your git client so that the commit author is your full name [1]: git config --global user.name "Firstname Lastname" Also, this patch is missing the 'Signed-off-by' line. That line is auto-generated by git if you provide the right flags to `git commit` or `git format-patch` (e.g. `git commit -s`, maybe create a git alias for that) Also, for single patches there is no need to send a cover-letter. If there is anything to be said about the patch that should *not* be part of the commit message, you can write it under the the '---' marker. Hope this helps :) [1] https://pve.proxmox.com/wiki/Developer_Documentation#Using_git On 10/9/23 11:38, hd wrote: > --- ^ I mean this marker here. > de.po | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/de.po b/de.po > index fea74f1..c647f31 100644 > --- a/de.po > +++ b/de.po > @@ -747,9 +747,8 @@ msgid "Authentication mode" > msgstr "Authentifikationsmodus" > > #: proxmox-widget-toolkit/src/panel/SendmailEditPanel.js:111 > -#, fuzzy > msgid "Author" > -msgstr "Auth-ID" > +msgstr "Autor" > > #: pmg-gui/js/TFAView.js:60 pve-manager/www/manager6/dc/OptionView.js:241 > #: proxmox-backup/www/config/WebauthnView.js:109 -- - Lukas