From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 987BA1FF164
	for <inbox@lore.proxmox.com>; Fri, 28 Mar 2025 09:56:00 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 3AFDF352FC;
	Fri, 28 Mar 2025 09:55:52 +0100 (CET)
Message-ID: <0a5af368-a827-4e54-94a9-53426de61735@proxmox.com>
Date: Fri, 28 Mar 2025 09:55:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250327115309.136068-1-f.ebner@proxmox.com>
 <01aa9a50-0d7e-45e0-b64c-19f0c7658103@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <01aa9a50-0d7e-45e0-b64c-19f0c7658103@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.040 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] applied: [PATCH edk2-firmware] add patch to revert
 addition of EFI memory attributes protocol for x86_64
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Am 27.03.25 um 17:39 schrieb Thomas Lamprecht:
> Am 27.03.25 um 12:53 schrieb Fiona Ebner:
>> Because of a long-standing bug in shim [0], booting will fail for
>> distibutions that do not include the fix yet, like Rocky Linux 9.5
>> and other CentOS-based distibutions. This is cased by the addition
>> of the EFI_MEMORY_ATTRIBUTE_PROTOCOL in edk2 commit efaa102d00
>> ("UefiCpuPkg: Produce EFI memory attributes protocol") for x86_64.
>>
>> Even with the fix in shim, issues in commonly shipped versions of GRUB
>> remain [1].
>>
>> This is relatively recent, i.e. in the edk2-stable202502 tag, and
>> since current non-minor distributions are still affected, revert the
>> problematic commit for now.
>>
>> Once issues are less common in distributions, an option to support
>> disabling it (via fw_cfg on the QEMU command line) can still be added
>> [1]. Then, it can also be nicely documented as a known issue while
>> giving users guidance.
>>
>> There already is a similar patch for ARM [2] inherited from the Debian
>> upstream version.
>>
>> The problematic commit is EFI_MEMORY_ATTRIBUTE_PROTOCOL was added for x86_64 recently in the
>> edk2-stable202502 tag. Since current non-minor distributions are still
>> affected, a revert is done for now.
>>
>> [0]: https://github.com/rhboot/shim/commit/c7b305152802c8db688605654f75e1195def9fd6
>> [1]: https://github.com/tianocore/edk2/pull/10667
>> [2]: ./debian/patches/ArmVirtPkg-disable-the-EFI_MEMORY_ATTRIBUTE-protocol.patch
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>  ...g-Produce-EFI-memory-attributes-prot.patch | 368 ++++++++++++++++++
>>  debian/patches/series                         |   1 +
>>  2 files changed, 369 insertions(+)
>>  create mode 100644 debian/patches/Revert-UefiCpuPkg-Produce-EFI-memory-attributes-prot.patch
>>
>>
> 
> applied, re-exported the revert using git format-patch as the unusual
> DOS line-endings that EDK2 source code uses seem to got lost somewhere
> along the way, and while I could have used quilt I figured there's no
> harm with format-patch, thanks!

Right, there's that issue with mailman (which I forgot about since the
last time this came up was nearly 2 years ago):
https://lore.proxmox.com/pve-devel/c72e637b-2e92-2ff5-0bc5-0c99d55b2ec8@proxmox.com/

CC-ing Stoiko


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel