From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB8C3620A2 for ; Mon, 23 Nov 2020 07:09:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE68223768 for ; Mon, 23 Nov 2020 07:08:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 98B282375B for ; Mon, 23 Nov 2020 07:08:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 69C2443CAB for ; Mon, 23 Nov 2020 07:08:55 +0100 (CET) To: Proxmox VE development discussion , Fabian Ebner References: <20201118100420.21167-1-f.ebner@proxmox.com> <20201118100420.21167-5-f.ebner@proxmox.com> From: Thomas Lamprecht Message-ID: <0a4015a2-b07a-036c-1f67-31977f45949e@proxmox.com> Date: Mon, 23 Nov 2020 07:08:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201118100420.21167-5-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.085 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v4 manager 4/4] ui: storage backup view: add prune window X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2020 06:09:26 -0000 On 18.11.20 11:04, Fabian Ebner wrote: > adapted from PBS. Main differences are: > * loading of the prune-backups options from the storage configurati= on if > configured > * API has GET/DELETE distinction instead of 'dry-run' > * API expects a single property string for the prune options >=20 > Also, had to change the clear trigger, because now there can be origina= l > values (from the storage config), but it doesn't really make sense to > reset to that value when clearing, so always set to 'null' when clearin= g >=20 > Signed-off-by: Fabian Ebner > --- >=20 > Changes from v3: > * don't use grouping headers with a prune button. Instead use a but= ton in > the toolbar which displays the group to be pruned > * always use 'lxc' and 'qemu' as backup types (which the PVE API ex= pects) instead > of 'VM' and 'CT' as types, to avoid some conversion >=20 I added the keep input field and a prune keep panel to proxmox-widget-too= lkit, so at least the input field should be reusable here.