From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A0B391FF0B2 for ; Mon, 24 Aug 2026 14:34:58 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6E187215F8; Mon, 24 Aug 2026 14:34:57 +0200 (CEST) Message-ID: <0945a4b6-a1dc-415a-88ab-0fe29d92968e@proxmox.com> Date: Mon, 24 Aug 2026 14:34:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH storage 1/1] cifs: match smbversion description with docs To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260226144316.451521-1-m.sandoval@proxmox.com> <20260226144316.451521-2-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260226144316.451521-2-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787574863290 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.843 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SFTHFEE5M4ICSJXE3LN7PUSWDDIUNULW X-Message-ID-Hash: SFTHFEE5M4ICSJXE3LN7PUSWDDIUNULW X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The circular reference in the commit titles are not telling much. Please use titles which better describe the changes. Am 26.02.26 um 3:43 PM schrieb Maximiliano Sandoval: > Signed-off-by: Maximiliano Sandoval > --- > src/PVE/Storage/CIFSPlugin.pm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm > index 54f0f4e..665ce1f 100644 > --- a/src/PVE/Storage/CIFSPlugin.pm > +++ b/src/PVE/Storage/CIFSPlugin.pm > @@ -147,9 +147,10 @@ sub properties { > maxLength => 256, > }, > smbversion => { > - description => > - "SMB protocol version. 'default' if not set, negotiates the highest SMB2+" > - . " version supported by both the client and server.", > + description => "SMB protocol version.", > + verbose_description => "SMB protocol version. When set to `default` or when unset," > + . " negotiates the highest SMB2+ version supported by both the client and server." > + . " SMB1 is not supported due to security issues.", While splitting description and verbose_description is sensible in general, in case of 'man pvesm', this means that the verbose information is not shown there anymore, which is not nice. So I held off from applying this one. We should either make sure the verbose information is shown there too (better solution) or just adapt the description. > type => 'string', > default => 'default', > enum => ['default', '2.0', '2.1', '3', '3.0', '3.11'],