From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A847798D0A for ; Tue, 18 Apr 2023 11:42:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 827D8CC4B for ; Tue, 18 Apr 2023 11:41:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 18 Apr 2023 11:41:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B5AA545795 for ; Tue, 18 Apr 2023 11:41:57 +0200 (CEST) Message-ID: <08cc2495-8238-46f2-4730-24d048f9edf2@proxmox.com> Date: Tue, 18 Apr 2023 11:41:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: Proxmox VE development discussion , Leo Nunner References: <20230418093144.61317-1-l.nunner@proxmox.com> <20230418093144.61317-2-l.nunner@proxmox.com> From: Lukas Wagner In-Reply-To: <20230418093144.61317-2-l.nunner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.986 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.284 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH container] api: network: get interfaces from containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2023 09:42:29 -0000 On 4/18/23 11:31, Leo Nunner wrote: > + foreach my $interface ($config->@*) { > + my $obj = { name => $interface->{ifname} }; > + foreach my $ip ($interface->{addr_info}->@*) { > + $obj->{$ip->{family}} = $ip->{local} . "/" . $ip->{prefixlen}; > + } > + $obj->{hwaddr} = $interface->{address}; > + push @$res, $obj > + } Nit, according to our style guide [1], `for` is to be preferred over `foreach`. [1] https://pve.proxmox.com/wiki/Perl_Style_Guide#Perl_syntax_choices -- - Lukas