From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path:
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 3B5199BA5D
for ; Tue, 21 Nov 2023 12:45:37 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0616C7A28
for ; Tue, 21 Nov 2023 12:45:07 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for ; Tue, 21 Nov 2023 12:45:06 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DE3F141025
for ; Tue, 21 Nov 2023 12:45:05 +0100 (CET)
Message-ID: <0893be93-e393-4ef0-b5ca-89da52301668@proxmox.com>
Date: Tue, 21 Nov 2023 12:45:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pve-devel@lists.proxmox.com
References: <20231121113657.194610-1-c.ebner@proxmox.com>
From: Philipp Hufnagl
In-Reply-To: <20231121113657.194610-1-c.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.053 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI
units for HD usage
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
X-List-Received-Date: Tue, 21 Nov 2023 11:45:37 -0000
On 11/21/23 12:36, Christian Ebner wrote:
> SI units are used for storage size information, as typically used by
> hard disk manufacturers.
>
> Change the root filesystem usage values in the node summary to be
> consistent.
>
> Signed-off-by: Christian Ebner
> ---
>
> Will also send a patch for PMG to be consistent across all of them.
>
> changes since v1:
> - use more compact renderer invocation, same as used in PBS
>
> www/manager6/node/StatusView.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
> index d34724f7..f6cd42ad 100644
> --- a/www/manager6/node/StatusView.js
> +++ b/www/manager6/node/StatusView.js
> @@ -72,7 +72,7 @@ Ext.define('PVE.node.StatusView', {
> title: '/ ' + gettext('HD space'),
> valueField: 'rootfs',
> maxField: 'rootfs',
> - renderer: Proxmox.Utils.render_node_size_usage,
> + renderer: ({ used, total }) => Proxmox.Utils.render_size_usage(used, total, true),
> },
> {
> iconCls: 'fa fa-fw fa-refresh',
LGTM
Tested-by: Philipp Hufnagl
Reviewed-by: Philipp Hufnagl