From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ACD3E91184 for ; Mon, 26 Sep 2022 11:40:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F86D2020 for ; Mon, 26 Sep 2022 11:40:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Sep 2022 11:40:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA92C4455A for ; Mon, 26 Sep 2022 11:40:36 +0200 (CEST) Message-ID: <07898f08-3610-c9be-fca8-de71ba35a609@proxmox.com> Date: Mon, 26 Sep 2022 11:40:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 Content-Language: en-GB To: Proxmox VE development discussion , Fiona Ebner References: <20220831124610.785526-1-f.ebner@proxmox.com> <20220831124610.785526-2-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220831124610.785526-2-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.860 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.766 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 2/2] config2cmd: warn when EFI disk is configured, but SeaBIOS is used X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2022 09:40:37 -0000 On 31/08/2022 14:46, Fiona Ebner wrote: > which can lead to operations like cloning the running VM failing. hmm, could be a bit spammy as warning, but we do not have a level between info and warning task log; log_notice() could be nice to get sometimes to have something that isn't as "alarming" as warnings, to avoid normalizing warnings, which could drown out a more "real" one (not saying this isn't problematic at all, but there may be some setups that test around with different boot/fw and want to avoid dropping the efidisk in between). What about ignoring the efidisk in the clone, and similar affected cases but warn there instead, while keep the start message here as info log (until we got a notice log level)? > > Signed-off-by: Fiona Ebner > --- > PVE/QemuServer.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 4e85dd02..3d7d70c5 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -3633,6 +3633,8 @@ sub config_to_command { > > push @$cmd, '-drive', "if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code"; > push @$cmd, '-drive', "if=pflash,unit=1$cache,format=$format,id=drive-efidisk0$size_str,file=${path}${read_only_str}"; > + } elsif ($conf->{efidisk0}) { > + log_warn("EFI disk was not attached, because SeaBIOS is used"); > } > > if ($q35) { # tell QEMU to load q35 config early